Skip to content

Commit

Permalink
Cran fixes (#10)
Browse files Browse the repository at this point in the history
* update description and export s3

* update cran comments

* bump patch v
  • Loading branch information
przybal2 authored Jun 17, 2024
1 parent 6003475 commit f95ffda
Show file tree
Hide file tree
Showing 7 changed files with 20 additions and 17 deletions.
12 changes: 6 additions & 6 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: beeca
Title: Binary Endpoint Estimation with Covariate Adjustment
Version: 0.1.2
Version: 0.1.3
Authors@R:
c(person(given = "Alex",
family = "Przybylski",
Expand All @@ -24,11 +24,11 @@ Authors@R:
email = "[email protected]",
role = c("aut")
))
Description: A lightweight package to perform estimation of marginal treatment
effects for binary outcomes when using logistic regression working models with
covariate adjustment (see discussions in Magirr et al (2024) <https://osf.io/9mp58/>). Implements the variance estimators of
Ge et al (2011) <doi:10.1177/009286151104500409> and
Ye et al (2023) <doi:10.1080/24754269.2023.2205802>.
Description: Performs estimation of marginal treatment effects for binary
outcomes when using logistic regression working models with covariate
adjustment (see discussions in Magirr et al (2024) <https://osf.io/9mp58/>).
Implements the variance estimators of Ge et al (2011) <doi:10.1177/009286151104500409>
and Ye et al (2023) <doi:10.1080/24754269.2023.2205802>.
Maintainer: Alex Przybylski <[email protected]>
License: LGPL (>= 3)
Encoding: UTF-8
Expand Down
1 change: 1 addition & 0 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ export(average_predictions)
export(estimate_varcov)
export(get_marginal_effect)
export(predict_counterfactuals)
export(sanitize_model)
importFrom(dplyr,as_tibble)
importFrom(lifecycle,deprecated)
importFrom(stats,cov)
Expand Down
2 changes: 1 addition & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# beeca 0.1.2
# beeca 0.1.3

- Preparation for CRAN submission

Expand Down
8 changes: 5 additions & 3 deletions R/sanitize.R
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
#' @param ... arguments passed to or from other methods.
#' @return if model is non-compliant will throw warnings or errors.
#' @keywords internal
#' @export
sanitize_model <- function(model, ...) {
UseMethod("sanitize_model")
}
Expand All @@ -27,10 +28,11 @@ sanitize_model <- function(model, ...) {
#' @importFrom stats model.frame model.matrix terms
#' @keywords internal
#' @export
#' @examples \dontrun{
#' @examples
#' trial01$trtp <- factor(trial01$trtp)
#' fit1 <- glm(aval ~ trtp + bl_cov, family = "binomial", data = trial01)
#' sanitize_model(fit1, "trtp")
#' }
#' fit1 <- sanitize_model(fit1, "trtp")
#'
sanitize_model.glm <- function(model, trt, ...) {
# sanitize variable
sanitize_variable(model, trt)
Expand Down
6 changes: 3 additions & 3 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@

This is a resubmission. In this version I have:

* Corrected URLs, DOIs, ORCID identifiers
* Updated the description to avoid starting with "A lightweight package..."

* Registered S3 methods
* Removed unnecessary \dontrun{} wrapper for an example

## R CMD check results

0 errors | 0 warnings | 1 note

I am aware of one possible note: The suggested package 'margins' was very recently reinstated to CRAN and binaries may not be available for certain platforms / R versions. At time of submission it is not available for Windows r-devel.
I am aware of one possible note: The suggested package 'margins' was very recently reinstated to CRAN and binaries may not be available for certain platforms / R versions.

```
* checking package dependencies ... NOTE
Expand Down
2 changes: 1 addition & 1 deletion man/beeca-package.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions man/sanitize_model.glm.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit f95ffda

Please sign in to comment.