Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Implement debounce to improve performance #46

Merged
merged 5 commits into from
Oct 30, 2023
Merged

refactor: Implement debounce to improve performance #46

merged 5 commits into from
Oct 30, 2023

Conversation

juancho0202
Copy link
Contributor

@juancho0202 juancho0202 commented Oct 25, 2023 •
edited
Loading

Closes #8

@juancho0202 juancho0202 requested a review from Stef3st October 25, 2023 14:17
@juancho0202 juancho0202 linked an issue Oct 25, 2023 that may be closed by this pull request
Implement debounce to improve performance #8
Closed
Stef3st
Stef3st suggested changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@Stef3st Stef3st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I have a few minor change suggestions

src/oscd-filtered-list.ts Outdated Show resolved Hide resolved
src/oscd-filtered-list.ts Outdated Show resolved Hide resolved
@Stef3st Stef3st merged commit d00f143 into main Oct 30, 2023
6 checks passed
@Stef3st Stef3st deleted the 8-implement-debounce branch October 30, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stef3st Stef3st Stef3st approved these changes

Assignees
No one assigned
Labels
None yet
Projects
PR Overview
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement debounce to improve performance
2 participants
@juancho0202 @Stef3st