Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] EOL of Node.js version 18.x used in Opensearch-dashboards #8463

Open
Chandana-EP opened this issue Oct 3, 2024 · 4 comments · May be fixed by #9171
Open

[BUG] EOL of Node.js version 18.x used in Opensearch-dashboards #8463

Chandana-EP opened this issue Oct 3, 2024 · 4 comments · May be fixed by #9171
Labels
bug Something isn't working

Comments

@Chandana-EP
Copy link

Node.js version 18.x will reach its end of life on April 30th, 2025.

Expected behavior
Opensearch-dashboards to not bundle dependencies/libraries that have reached EOL and aren't supported anymore.

Dashboards Version
2.14.0

When can we expect the NodeJS Non-EOL version update for Opensearch Dashboards ??

@Chandana-EP Chandana-EP added bug Something isn't working untriaged labels Oct 3, 2024
@ananzh
Copy link
Member

ananzh commented Oct 15, 2024

Node 18 ends security support on 4/30/2025.

https://endoflife.date/nodejs

Should we plan to bump to 20 or 22?

CC: @ashwin-pc @AMoo-Miki

@AMoo-Miki
Copy link
Collaborator

Due to its commitment to backward compatibility within a major version, OSD 2.x will need to support Node.js versions 14, 16, and 18. It is likely that OSD will need to upgrade or replace numerous libraries to ensure compatibility with Node.js 20 or 22 during both the development and runtime execution phases. While some libraries may run correctly with an older version of Node.js at runtime, developing with them on older Node.js versions may not be possible. If these upgrades impose any breaking changes, it is highly probable that Node.js upgrades will need to be deferred until the release of OSD 3.x.

In my opinion, there should be no issues using OSD 2.x runtime on Node.js 20 or 22, and the documentation provides instructions for utilizing these versions in your runtime environment. Maybe post back if you give it a shot.

@mrudrego
Copy link

@AMoo-Miki , any idea when OSD 3.x is planned to be released ?

Thanks,

@AMoo-Miki
Copy link
Collaborator

@AMoo-Miki , any idea when OSD 3.x is planned to be released ?

According to this, not in the near future.

hashworks added a commit to hashworks/OpenSearch-Dashboards that referenced this issue Jan 10, 2025
NodeJS 18 "Hydrogen" will be EOL in April 2025.

Closes issue opensearch-project#8463.

Signed-off-by: hashworks <[email protected]>
hashworks added a commit to hashworks/OpenSearch-Dashboards that referenced this issue Jan 10, 2025
NodeJS 18 "Hydrogen" will be EOL in April 2025.

Closes issue opensearch-project#8463.

Note: I used `yarn upgrade require-in-the-middle` and `yarn upgrade
elastic-apm-node` to fix build issues:

```
ERROR Error: Command failed with exit code 1: /usr/lib/node_modules/yarn/bin/yarn.js run osd:bootstrap
      (node:2289) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
      (Use `node --trace-deprecation ...` to show where the warning was created)
      Node.js process-warning detected:

      DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
          at node:punycode:3:9
          at BuiltinModule.compileForInternalLoader (node:internal/bootstrap/realm:399:7)
          at BuiltinModule.compileForPublicLoader (node:internal/bootstrap/realm:338:10)
          at loadBuiltinModule (node:internal/modules/helpers:110:7)
          at Function._load (node:internal/modules/cjs/loader:1095:17)
          at TracingChannel.traceSync (node:diagnostics_channel:322:14)
          at wrapModuleLoad (node:internal/modules/cjs/loader:217:24)
          at Module.<anonymous> (node:internal/modules/cjs/loader:1335:12)
          at Module.Hook._require.Module.require (/build/opensearch-dashboards/src/OpenSearch-Dashboards/node_modules/require-in-the-middle/index.js:80:39)
```

Signed-off-by: hashworks <[email protected]>
hashworks added a commit to hashworks/OpenSearch-Dashboards that referenced this issue Jan 10, 2025
NodeJS 18 "Hydrogen" will be EOL in April 2025.

Closes issue opensearch-project#8463.

Note: The latest LTS (22 "Jod") fails to build.

Signed-off-by: hashworks <[email protected]>
@hashworks hashworks linked a pull request Jan 10, 2025 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants