Remove bypass of getting cypress cache #9209
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: abbyhu2000 <[email protected]>
abbyhu2000
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
angle943
approved these changes
Jan 17, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9209 +/- ##
==========================================
- Coverage 61.05% 61.02% -0.03%
==========================================
Files 3816 3816
Lines 91492 91492
Branches 14459 14459
==========================================
- Hits 55857 55835 -22
- Misses 32070 32138 +68
+ Partials 3565 3519 -46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
7 tasks
ananzh
approved these changes
Jan 18, 2025
kavilla
approved these changes
Jan 21, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
* get cypress cache Signed-off-by: abbyhu2000 <[email protected]> * Changeset file for PR #9209 created/updated --------- Signed-off-by: abbyhu2000 <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 4ebb204) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
FriedhelmWS
pushed a commit
to FriedhelmWS/OpenSearch-Dashboards
that referenced
this pull request
Jan 22, 2025
* get cypress cache Signed-off-by: abbyhu2000 <[email protected]> * Changeset file for PR opensearch-project#9209 created/updated --------- Signed-off-by: abbyhu2000 <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
ananzh
pushed a commit
that referenced
this pull request
Jan 22, 2025
* get cypress cache * Changeset file for PR #9209 created/updated --------- (cherry picked from commit 4ebb204) Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cypress should only install the version defined in package.json.
Issues Resolved
Cigroup11 failture on main and 2.x because
env: 'cypress': Permission deniedbecause cypress is installing version 14Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration