Stop processing search requests when _msearch is canceled #17005
Conversation
msfroh
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
❌ Gradle check result for b88b6d5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
msfroh
force-pushed
the
cancel_msearch
branch
from
b88b6d5 to
30d127a
Compare
|
❕ Gradle check result for 30d127a: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17005 +/- ##
============================================
+ Coverage 72.21% 72.27% +0.05%
- Complexity 65289 65296 +7
============================================
Files 5301 5301
Lines 303725 303766 +41
Branches 44008 44018 +10
============================================
+ Hits 219340 219545 +205
+ Misses 66394 66256 -138
+ Partials 17991 17965 -26 ☔ View full report in Codecov by Sentry. |
server/src/main/java/org/opensearch/action/search/TransportMultiSearchAction.java
Outdated
Show resolved
Hide resolved
reta
added
v3.0.0
|
❌ Gradle check result for 48bf890: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 48bf890: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Prior to this fix, the _msearch API would keep running search requests even after being canceled. With this change, we explicitly check if the task has been canceled before kicking off subsequent requests. Signed-off-by: Michael Froh <[email protected]>
I tried cancelling a request and found that the client would hang. This change reports an exception for each remaining request instead. Signed-off-by: Michael Froh <[email protected]>
Signed-off-by: Michael Froh <[email protected]>
msfroh
force-pushed
the
cancel_msearch
branch
from
48bf890 to
44b2bb6
Compare
|
❌ Gradle check result for 44b2bb6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Description
Prior to this fix, the _msearch API would keep running search requests even after being canceled. With this change, we explicitly check if the task has been canceled before kicking off subsequent requests.
Related Issues
Resolves #17004
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.