Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable flatten result index option for existing detectors #965

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

jackiehanyang
Copy link
Collaborator

Description

disable the flatten result index option when:

  • is on edit page
  • is using custom result index
  • flatten result index is not checked for existing detector config

customer can chose to create a detector with flatten result index option, and then later on edit page, they can uncheck it to disable flatten result index.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jackiehanyang jackiehanyang merged commit c51aca0 into opensearch-project:main Jan 28, 2025
9 of 11 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-965-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c51aca0c653d5636a8c9e44809d1df437034f4a9
# Push it to GitHub
git push --set-upstream origin backport/backport-965-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-965-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-965-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c51aca0c653d5636a8c9e44809d1df437034f4a9
# Push it to GitHub
git push --set-upstream origin backport/backport-965-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-965-to-2.x.

jackiehanyang added a commit to jackiehanyang/anomaly-detection-dashboards-plugin that referenced this pull request Feb 3, 2025
jackiehanyang added a commit that referenced this pull request Feb 3, 2025
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 3, 2025
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 3, 2025
jackiehanyang added a commit that referenced this pull request Feb 3, 2025
)" (#970) (#971)

This reverts commit c51aca0.

(cherry picked from commit b47d048)

Co-authored-by: Jackie Han <[email protected]>
jackiehanyang added a commit that referenced this pull request Feb 3, 2025
)" (#970) (#972)

This reverts commit c51aca0.

(cherry picked from commit b47d048)

Co-authored-by: Jackie Han <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants