Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct log4j2 syntax in the example #479

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

peternied
Copy link
Member

Description

In the yml format in of the log4j properties file, a logger is declared with logger.LOGGER_NAME.name, the value of LOGGER_NAME can be set as desired by the user. When the example included the . operator it was treated as another object and 'security' was referenced as a key which didn't resolve to anything.

Issues Resolved

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peternied peternied requested a review from a team as a code owner March 29, 2022 20:53
@peternied peternied self-assigned this Mar 29, 2022
@peternied peternied added bug Technical problem with the doc site or broken link xx-documentation Improvements or additions to documentation labels Mar 29, 2022
In the [yml format](https://logging.apache.org/log4j/2.x/manual/configuration.html#Configuration_with_Properties) in of the log4j properties file, a logger is declared with logger.LOGGER_NAME.name, the value of LOGGER_NAME can be set as desired by the user.  When the example included the `.` operator it was treated as another object and 'security' was referenced as a key which didn't resolve to anything.

Signed-off-by: Peter Nied <[email protected]>
@peternied
Copy link
Member Author

FYI @opensearch-project/security

Copy link
Contributor

@keithhc2 keithhc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keithhc2 keithhc2 requested a review from Naarcha-AWS March 30, 2022 17:44
@Naarcha-AWS Naarcha-AWS merged commit 681e166 into opensearch-project:main Mar 31, 2022
@peternied peternied deleted the peternied-oidc branch March 31, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Technical problem with the doc site or broken link xx-documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Unable to configure debug/trace logging for security plugins [BUG] Trace logging for OIDC
5 participants