Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Use string-based version parsing to improve portability #1068

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 88fe98e from #1067.

Signed-off-by: Daniel Widdis <[email protected]>
(cherry picked from commit 88fe98e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 75.57%. Comparing base (c5450fb) to head (c61bee0).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ramework/transport/ReprovisionWorkflowRequest.java 0.00% 0 Missing and 2 partials ⚠️
...earch/flowframework/transport/WorkflowRequest.java 0.00% 0 Missing and 2 partials ⚠️
...arch/flowframework/transport/WorkflowResponse.java 0.00% 0 Missing and 2 partials ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff            @@
##                2.x    #1068   +/-   ##
=========================================
  Coverage     75.57%   75.57%           
  Complexity     1050     1050           
=========================================
  Files           101      101           
  Lines          5212     5212           
  Branches        498      498           
=========================================
  Hits           3939     3939           
  Misses         1035     1035           
  Partials        238      238           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbwiddis dbwiddis merged commit 73f0188 into 2.x Feb 25, 2025
32 of 33 checks passed
@dbwiddis dbwiddis deleted the backport/backport-1067-to-2.x branch February 25, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant