Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor settings management for plugin #1393

Closed
wants to merge 18 commits into from

Move index_thread_qty to KNNCodecService

cb5c451
Select commit
Loading
Failed to load commit list.
Closed

Refactor settings management for plugin #1393

Move index_thread_qty to KNNCodecService
cb5c451
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/patch failed Jan 24, 2024 in 1s

83.24% of diff hit (target 84.92%)

View this Pull Request on Codecov

83.24% of diff hit (target 84.92%)

Annotations

Check warning on line 55 in src/main/java/org/opensearch/knn/index/KNNCircuitBreaker.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/knn/index/KNNCircuitBreaker.java#L55 

Added line #L55 was not covered by tests

Check warning on line 59 in src/main/java/org/opensearch/knn/index/KNNCircuitBreaker.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/knn/index/KNNCircuitBreaker.java#L59 

Added line #L59 was not covered by tests

Check warning on line 65 in src/main/java/org/opensearch/knn/index/KNNCircuitBreaker.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/knn/index/KNNCircuitBreaker.java#L64-L65 

Added lines #L64 - L65 were not covered by tests

Check warning on line 124 in src/main/java/org/opensearch/knn/index/KNNCircuitBreaker.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/knn/index/KNNCircuitBreaker.java#L123-L124 

Added lines #L123 - L124 were not covered by tests

Check warning on line 142 in src/main/java/org/opensearch/knn/index/KNNCircuitBreaker.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/knn/index/KNNCircuitBreaker.java#L140-L142 

Added lines #L140 - L142 were not covered by tests

Check warning on line 146 in src/main/java/org/opensearch/knn/index/KNNCircuitBreaker.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/knn/index/KNNCircuitBreaker.java#L146 

Added line #L146 was not covered by tests

Check warning on line 148 in src/main/java/org/opensearch/knn/index/KNNCircuitBreaker.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/knn/index/KNNCircuitBreaker.java#L148 

Added line #L148 was not covered by tests

Check warning on line 78 in src/main/java/org/opensearch/knn/index/KNNCircuitBreakerUtil.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/knn/index/KNNCircuitBreakerUtil.java#L78 

Added line #L78 was not covered by tests

Check warning on line 105 in src/main/java/org/opensearch/knn/index/KNNCircuitBreakerUtil.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/knn/index/KNNCircuitBreakerUtil.java#L105 

Added line #L105 was not covered by tests

Check warning on line 108 in src/main/java/org/opensearch/knn/index/KNNCircuitBreakerUtil.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/knn/index/KNNCircuitBreakerUtil.java#L107-L108 

Added lines #L107 - L108 were not covered by tests

Check warning on line 110 in src/main/java/org/opensearch/knn/index/KNNCircuitBreakerUtil.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/knn/index/KNNCircuitBreakerUtil.java#L110 

Added line #L110 was not covered by tests

Check warning on line 138 in src/main/java/org/opensearch/knn/index/KNNCircuitBreakerUtil.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/knn/index/KNNCircuitBreakerUtil.java#L138 

Added line #L138 was not covered by tests

Check warning on line 53 in src/main/java/org/opensearch/knn/indices/ModelCache.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/knn/indices/ModelCache.java#L53 

Added line #L53 was not covered by tests

Check warning on line 56 in src/main/java/org/opensearch/knn/indices/ModelCache.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/knn/indices/ModelCache.java#L56 

Added line #L56 was not covered by tests

Check warning on line 58 in src/main/java/org/opensearch/knn/indices/ModelCache.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/knn/indices/ModelCache.java#L58 

Added line #L58 was not covered by tests
View more details on Codecov