Add filter function to KNNQueryBuilder #2585
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chloe Gao <[email protected]>
shatejas
reviewed
Mar 6, 2025
| * @param filterToBeAdded filter to be added | ||
| * @return return itself with underlying filter combined with passed in filter | ||
| */ | ||
| public QueryBuilder filter(QueryBuilder filterToBeAdded) { |
There was a problem hiding this comment.
There is a Builder created to be able to set the filter - why is this needed?
There was a problem hiding this comment.
This is for the issue here opensearch-project/neural-search#1135 where we want to add common filter from HybridQueryBuilder to all queries below, including KNNQueryBuilder. So it means adding additional filter to previous filter.
There was a problem hiding this comment.
Modifying an existing query builder is not a great idea, the builder is created to make sure its immutable in a way and every parameter is validated together rather than individually - you need to create a copy of it in neural side to support the use case
KNNQueryBuilder initialqueryBuidler = //whatever it is
KNNQueryBuilder filterQueryBuilder = KNNQueryBuilder.builder().filter(filterTobeAdded).k(initialQuery.k()) and so on before calling .build()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add filter function to KNNQueryBuilder
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.