Removes Array based vector serialization #2587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmazanec15
added
the
Maintenance
jmazanec15
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan,
luyuncheng,
shatejas,
0ctopus13prime and
Vikasht34
as code owners
Previously, we had serialized vectors via an array method. This was inefficient and remove in the opensearch-project#253 PR and launced in 1.3.0. With that, we no longer serialized new segment data via the array based serializer. Now that it is 3.0, because the oldest index that can be upgraded is from 1.3.0, we no longer need to handle array based serialization. So, we can remove all of it. Signed-off-by: John Mazanec <[email protected]>
jmazanec15
force-pushed
the
remove-bwc-serialize
branch
from
4f7a238 to
20fac6d
Compare
martin-gaievski
approved these changes
Mar 7, 2025
naveentatikonda
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, we had serialized vectors via an array method. This was inefficient and deprecated and switched in #253 and released in 1.3.0. With that, we no longer serialized new segment data via the array based serializer. Now that it is 3.0, because the oldest index that can be upgraded is from 1.3.0 (https://opensearch.org/docs/latest/install-and-configure/upgrade-opensearch/index/#compatibility), we no longer need to handle array based serialization. So, we can remove all of it.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.