Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nox generate #830

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Fix nox generate #830

merged 2 commits into from
Sep 27, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Sep 27, 2024

Description

Fixing the generator-caused failures in #814.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.34%. Comparing base (ba715b9) to head (dcf379b).
Report is 64 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #830      +/-   ##
==========================================
- Coverage   71.95%   70.34%   -1.61%     
==========================================
  Files          91      113      +22     
  Lines        8001     8896     +895     
==========================================
+ Hits         5757     6258     +501     
- Misses       2244     2638     +394     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saimedhi saimedhi merged commit 44f712e into opensearch-project:main Sep 27, 2024
35 of 43 checks passed
@dblock dblock deleted the fix-nox-generate branch September 27, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skips changelog verifier
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants