Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix imports related to split package of org.opensearch.transport #3325

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LantaoJin
Copy link
Member

@LantaoJin LantaoJin commented Feb 17, 2025

Description

Fix imports related to split package of org.opensearch.transport

Related to opensearch-project/OpenSearch#17272

Related Issues

Resolves #3324

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@LantaoJin
Copy link
Member Author

This two classes continue fail in compiling until related repositories upgraded.
https://github.com/opensearch-project/geospatial

opensearch/src/main/java/org/opensearch/sql/opensearch/planner/physical/OpenSearchEvalProcessor.java:53: error: cannot access NodeClient
    IpEnrichmentActionClient ipClient = new IpEnrichmentActionClient(nodeClient);

https://github.com/opensearch-project/ml-commons

opensearch/src/main/java/org/opensearch/sql/opensearch/client/MLClient.java:19: error: cannot access Client
      INSTANCE = new MachineLearningNodeClient(nodeClient);

cc @peterzhuamazon

@LantaoJin
Copy link
Member Author

Regarding to the CI logs of another PR. I found the OpenSearch artifact we download is version[3.0.0-SNAPSHOT], pid[1758], build[tar/a3717aebc7553ca8dbb96f4b3e0961ced5913113/2025-01-23T21:30:01.685571287Z]. The upstream changes introduced after 2025-02-07, not sure why the CI workflow haven't update its artifact. Node cache?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Upstream Client dependency package moved
1 participant