Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carry .syft.yaml on branch cut too #1008

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

creydr
Copy link
Member

@creydr creydr commented Dec 12, 2024

As per title

/hold until #1007 merged

@creydr
Copy link
Member Author

creydr commented Jan 28, 2025

/lgtm

Copy link

openshift-ci bot commented Jan 28, 2025

@creydr: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@creydr
Copy link
Member Author

creydr commented Jan 28, 2025

Obviously I can't LGTM my own PR :D
/assign @matejvasek

@matejvasek
Copy link
Collaborator

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 28, 2025
Copy link

openshift-ci bot commented Jan 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matejvasek
Copy link
Collaborator

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit 2e16f0c into openshift-knative:main Jan 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants