OCPBUGS-49785: ztp: Default WPC-GM MaxInSpecOffset to 1500 and allow user configuration of all settings values #2215
Conversation
…ion of all settings values Signed-off-by: Jim Ramsay <[email protected]>
openshift-ci-robot
added
jira/valid-reference
|
@lack: This pull request references Jira Issue OCPBUGS-49785, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
| LocalMaxHoldoverOffSet: 1500 | ||
| LocalHoldoverTimeout: 14400 | ||
| MaxInSpecOffset: 100 | ||
| {{- .plugins.e810.settings | toYaml | nindent 10 }} |
There was a problem hiding this comment.
As usual, the template allows users to set anything they want here.
| LocalHoldoverTimeout: 14400 | ||
| MaxInSpecOffset: 100 | ||
| LocalMaxHoldoverOffSet: 1500 | ||
| MaxInSpecOffset: 1500 |
There was a problem hiding this comment.
Important difference 100 -> 1500 as per OCPBUGS-49785
|
/retest |
|
@lack: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aneeshkp, lack The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 45b69ec
into
openshift-kni:master
|
@lack: Jira Issue OCPBUGS-49785: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-49785 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-4.18 |
|
@lack: new pull request created: #2219 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Jim Ramsay [email protected]