Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upversion golang to 1.22 #668

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sudomakeinstall2
Copy link
Contributor

Background / Context

Issue / Requirement / Reason for change

Solution / Feature Overview

Implementation Details

Other Information

@openshift-ci openshift-ci bot requested review from rauhersu and tsorya October 3, 2024 15:32
@rauhersu
Copy link

rauhersu commented Oct 3, 2024

/hold

We need to incorporate these changes in downstream first, also you might want to take a look at openshift ci (if this has not been coordinated) as quay.io builds will likely need to update the builders too.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2024
@rauhersu
Copy link

rauhersu commented Oct 4, 2024

/unhold

All good !

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2024
@jc-rh
Copy link
Member

jc-rh commented Oct 15, 2024

/retest

@sudomakeinstall2 sudomakeinstall2 force-pushed the upversion-go-1.22 branch 2 times, most recently from 2a32fa7 to 13f6ecc Compare November 6, 2024 22:45
@sudomakeinstall2
Copy link
Contributor Author

/retest

@sudomakeinstall2 sudomakeinstall2 force-pushed the upversion-go-1.22 branch 4 times, most recently from feecd0b to f899e31 Compare November 13, 2024 18:59
Signed-off-by: Saeid Askari <[email protected]>

Upversion controller-gen to v0.14.0

Signed-off-by: Saeid Askari <[email protected]>
@jc-rh
Copy link
Member

jc-rh commented Nov 15, 2024

/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2024
Copy link
Contributor

openshift-ci bot commented Nov 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jc-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2024
Copy link
Contributor

openshift-ci bot commented Nov 15, 2024

New changes are detected. LGTM label has been removed.

@sudomakeinstall2
Copy link
Contributor Author

/retest

Copy link
Contributor

openshift-ci bot commented Nov 16, 2024

@sudomakeinstall2: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ibi-e2e-flow b673180 link false /test ibi-e2e-flow
ci/prow/ibu-e2e-flow b673180 link false /test ibu-e2e-flow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants