test

pkg/aws/validations/iam_helpers.go

@@ -14,6 +14,12 @@ import (
 	cmv1 "github.com/openshift-online/ocm-sdk-go/clustersmgmt/v1"
 )
 
+const (
+	duplicateIamRoleArnErrorMsg = "ROSA IAM roles must have unique ARNs " +
+		"and should not be shared with other IAM roles within the same cluster. " +
+		"Duplicated role arn: %s"
+)
+
 func GetRoleName(prefix string, role string) string {
 	name := fmt.Sprintf("%s-%s-Role", prefix, role)
 	if len(name) > MaxAwsRoleLength {
@@ -75,8 +81,7 @@ func IamRoleArnsValidator(cluster *cmv1.Cluster) error {
 
 	for _, arn := range clusterIamRoles {
 		if _, exist := validatingMap[arn]; exist {
-			return fmt.Errorf("ROSA IAM roles requires unique ARNs and should not be shared by other cluster IAM roles. "+
-				"Duplicated role arn: %s", arn)
+			return fmt.Errorf(duplicateIamRoleArnErrorMsg, arn)
 		}
 		validatingMap[arn] = struct{}{}
 	}

pkg/aws/validations/iam_helpers_test.go

@@ -164,8 +164,7 @@ var _ = Describe("AWS iamtypes Functions", func() {
 			err = IamRoleArnsValidator(fakeCluster)
 			Expect(err).To(HaveOccurred())
 			Expect(err.Error()).To(Equal(
-				fmt.Sprintf("ROSA IAM roles requires unique ARNs and should not be shared by other cluster IAM roles. "+
-					"Duplicated role arn: %s", "installer"),
+				fmt.Sprintf(duplicateIamRoleArnErrorMsg, "installer"),
 			))
 		})