OCM-6312 | Migrate aws v1 methods from openshift-rosa-cli to aws v2 methods in ocm-common #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
ciaranRoche
reviewed
Apr 16, 2024
ciaranRoche
reviewed
Apr 17, 2024
OAharoni-RedHat
force-pushed
the
main
branch
2 times, most recently
from
9adcb8d to
efabf73
Compare
OAharoni-RedHat
changed the title
|
@OAharoni-RedHat The commit message is too long and wrapped with |
xueli181114
reviewed
Apr 23, 2024
OAharoni-RedHat
force-pushed
the
main
branch
3 times, most recently
from
95388ea to
712f68f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR was made here and included transferring all of the AWS methods from openshift-rosa-cli to ocm-common. Instead, the first part of migrating all of the existing aws v2 methods to ocm-common was done in this PR. This new PR only includes migrating the v1 methods which were still in use in openshift-rosa-cli to ocm-common and shifting them to use AWS v2.