OCM-8256 | feat: add methods to attach policies #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
|
@robpblake Would you help take a look? Thanks |
robpblake
reviewed
Jun 12, 2024
robpblake
reviewed
Jun 12, 2024
robpblake
reviewed
Jun 12, 2024
OAharoni-RedHat
force-pushed
the
new-methods
branch
from
8408570 to
180b753
Compare
|
@robpblake @xueli181114 @yingzhanredhat do we have any comments on this PR at this point? Would love to close this out if we don't have any more comments |
robpblake
reviewed
Jun 27, 2024
robpblake
reviewed
Jun 27, 2024
OAharoni-RedHat
force-pushed
the
new-methods
branch
from
180b753 to
3e91655
Compare
Merge branch 'main' into new-methods
OAharoni-RedHat
force-pushed
the
new-methods
branch
from
c01f753 to
d9fcf97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 new method: CreateRoleAndAttachPolicy
other added methods are migrated from openshift-rosa-cli: https://github.com/OAharoni-RedHat/openshift-rosa-cli/blob/master/pkg/aws_client/aws_v1/role.go
Original Pull request seems to have broken commit, remaking here.