Skip to content

Commit

Permalink
Update enhancement proposal to support update of user-defined AWS tags (
Browse files Browse the repository at this point in the history
#1051)

* Update details about updatable tags and precedence

* Addressed review comments

* Update enhancements/api-review/custom-tags-aws.md

Co-authored-by: Matthew Staebler <[email protected]>

* Update enhancements/api-review/custom-tags-aws.md

Co-authored-by: Matthew Staebler <[email protected]>

* Update enhancements/api-review/custom-tags-aws.md

Co-authored-by: Matthew Staebler <[email protected]>

* Update enhancements/api-review/custom-tags-aws.md

Co-authored-by: Matthew Staebler <[email protected]>

* Update enhancements/api-review/custom-tags-aws.md

Co-authored-by: Matthew Staebler <[email protected]>

* Update enhancements/api-review/custom-tags-aws.md

Co-authored-by: Matthew Staebler <[email protected]>

* Update enhancements/api-review/custom-tags-aws.md

Co-authored-by: Matthew Staebler <[email protected]>

* Update enhancements/api-review/custom-tags-aws.md

Co-authored-by: Matthew Staebler <[email protected]>

* Update enhancements/api-review/custom-tags-aws.md

Co-authored-by: Matthew Staebler <[email protected]>

* Update enhancements/api-review/custom-tags-aws.md

Co-authored-by: Matthew Staebler <[email protected]>

* Update enhancements/api-review/custom-tags-aws.md

Co-authored-by: Matthew Staebler <[email protected]>

* addressed review suggestions 15032022

* updated format errors

* add remove tag behaviour in CRD comments

* add remove tag behaviour in CRD

* update status for event

* Updated enhancement for delete scenario, api extensions

* Update the api comment documentation

* Update api maxItems for tags

* Update enhancements/api-review/custom-tags-aws.md

Co-authored-by: Joel Speed <[email protected]>

* update documentation for types

* Update enhancements/api-review/custom-tags-aws.md

Co-authored-by: Joel Speed <[email protected]>

* Update enhancements/api-review/custom-tags-aws.md

Co-authored-by: Joel Speed <[email protected]>

* Updated for review suggestions on specifics

* Update enhancements/api-review/custom-tags-aws.md

Co-authored-by: Matthew Staebler <[email protected]>

* updated for reviews on duplicate caveat

* updated as per suggestion from api team, to be handled in admission plugin

Co-authored-by: Matthew Staebler <[email protected]>
Co-authored-by: Joel Speed <[email protected]>
  • Loading branch information
3 people authored Apr 4, 2022
1 parent e07e030 commit c542b12
Showing 1 changed file with 366 additions and 39 deletions.
Loading

0 comments on commit c542b12

Please sign in to comment.