Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(KFLUXBUGS-1342): add existing secret in the components secret form #1006

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

fix: list existing secret in build time secret modal

af95dff
Select commit
Loading
Failed to load commit list.
Open

fix(KFLUXBUGS-1342): add existing secret in the components secret form #1006

fix: list existing secret in build time secret modal
af95dff
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 14, 2024 in 0s

85.00% (-0.02%) compared to 8833c6b

View this Pull Request on Codecov

85.00% (-0.02%) compared to 8833c6b

Details

Codecov Report

Attention: Patch coverage is 93.47826% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.00%. Comparing base (8833c6b) to head (af95dff).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/components/Secrets/SecretForm.tsx 87.50% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1006      +/-   ##
==========================================
- Coverage   85.01%   85.00%   -0.02%     
==========================================
  Files         582      582              
  Lines       14333    14349      +16     
  Branches     4010     4016       +6     
==========================================
+ Hits        12185    12197      +12     
- Misses       2021     2025       +4     
  Partials      127      127              
Files with missing lines Coverage Δ
...ponents/ImportForm/SecretSection/SecretSection.tsx 81.08% <100.00%> (+4.15%) ⬆️
src/components/ImportForm/submit-utils.ts 94.59% <100.00%> (+0.30%) ⬆️
src/components/Secrets/SecretModal.tsx 100.00% <100.00%> (ø)
src/components/Secrets/SecretModalLauncher.tsx 80.00% <ø> (ø)
src/components/Secrets/utils/secret-utils.ts 96.92% <100.00%> (+0.07%) ⬆️
src/types/secret.ts 100.00% <ø> (ø)
src/utils/validation-utils.ts 100.00% <100.00%> (ø)
src/components/Secrets/SecretForm.tsx 78.68% <87.50%> (+7.25%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8833c6b...af95dff. Read the comment docs.