Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-5.8] Backport metrics and status handling from 5.9 #337

Conversation

xperimental
Copy link

@xperimental xperimental commented Jul 29, 2024

What this PR does / why we need it:

This PR combines multiple changes that were backported to 5.9 and backports them to 5.8:

This should bring 5.8 in line with the newer releases regarding metrics and bring the improvements we made to the handling of the status conditions back to 5.8 as well.

Which issue(s) this PR fixes:

Fixes LOG-5857

@xperimental xperimental requested a review from periklis as a code owner July 29, 2024 18:55
@openshift-ci openshift-ci bot requested review from shwetaap and vimalk78 July 29, 2024 18:55
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2024
Copy link

openshift-ci bot commented Jul 29, 2024

@xperimental: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2024
Copy link

openshift-ci bot commented Jul 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: periklis, xperimental

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [periklis,xperimental]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 628b254 into openshift:release-5.8 Jul 30, 2024
7 checks passed
@xperimental xperimental deleted the fix-duplicate-condition-5.8 branch July 30, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants