-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.18] OCPBUGS-49433: create /run/nodeip-configuration before use #4813
[release-4.18] OCPBUGS-49433: create /run/nodeip-configuration before use #4813
Conversation
With nmstate `br-ex` creation using static IP, it looks like the systemd boot ordering can change and we can attempt to run `30-resolv-prepender` before `nodeip-configuration.service`. When `30-resolv-prepender` runs it tries to touch a file in `/run/nodeip-configuration` when it does not exist. ```log nm-dispatcher[2409]: touch: cannot touch '/run/nodeip-configuration/br-ex-up': No such file or directory ``` The quick fix is to always mkdir before touching, then we don't have to track the global state of `/run/nodeip-configuration`
@openshift-cherrypick-robot: Jira Issue OCPBUGS-46072 has been cloned as Jira Issue OCPBUGS-49433. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-49433, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/lgtm |
/retest-required |
/label cherry-pick-approved |
/jira refresh |
@cybertron: This pull request references Jira Issue OCPBUGS-49433, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cybertron, djoshy, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/retest-required This doesn't affect AWS jobs so it can't have caused those failures. |
120ba67
into
openshift:release-4.18
@openshift-cherrypick-robot: Jira Issue OCPBUGS-49433: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-49433 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] Distgit: ose-machine-config-operator |
/cherrypick release-4.17 |
@cybertron: new pull request created: #4858 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is an automated cherry-pick of #4798
/assign cybertron