Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show backup/restore progress in NAB/NAR status #1649

Merged

Conversation

mateusoliveira43
Copy link
Contributor

Why the changes were made

migtools/oadp-non-admin#237

How to test the changes made

Follow instructions on NAC PR migtools/oadp-non-admin#239

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2025
@weshayutin
Copy link
Contributor

This PR and migtools/oadp-non-admin#237 tested on OCP 4.19 worked for me.. see my updates in 237 :)

@mpryc
Copy link
Contributor

mpryc commented Mar 3, 2025

/retest

Copy link
Contributor

@mpryc mpryc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2025
@mpryc
Copy link
Contributor

mpryc commented Mar 3, 2025

/hold

Actually there is one unresolved comment which may change this:
migtools/oadp-non-admin#239 (comment)

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2025
@mpryc
Copy link
Contributor

mpryc commented Mar 3, 2025

/test 4.16-e2e-test-aws

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2025
@mpryc
Copy link
Contributor

mpryc commented Mar 3, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2025
@mateusoliveira43
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2025
Copy link

openshift-ci bot commented Mar 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, mateusoliveira43, mpryc, shubham-pampattiwar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kaovilai,mateusoliveira43,mpryc,shubham-pampattiwar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mpryc
Copy link
Contributor

mpryc commented Mar 3, 2025

/test 4.18-e2e-test-aws

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4347f5d and 2 for PR HEAD 7843cca in total

@mpryc
Copy link
Contributor

mpryc commented Mar 3, 2025

/test 4.14-e2e-test-aws

@mpryc
Copy link
Contributor

mpryc commented Mar 3, 2025

/retest

@weshayutin weshayutin merged commit 8115b66 into openshift:master Mar 3, 2025
22 of 26 checks passed
Copy link

openshift-ci bot commented Mar 3, 2025

@mateusoliveira43: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.18-e2e-test-aws 7843cca link false /test 4.18-e2e-test-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants