-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding OSD and ROSA to the Travis configuration #40591
Adding OSD and ROSA to the Travis configuration #40591
Conversation
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: b83f4db 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61e18e0a86f73a0007eeb473 😎 Browse the preview: https://deploy-preview-40591--osdocs.netlify.app |
649a91b
to
8d89969
Compare
8d89969
to
b83f4db
Compare
@pneedle-rh Great catch and these changes LGTM. I'm personally not sure about the impact on other uses for the |
@@ -14,6 +14,8 @@ install: | |||
|
|||
script: | |||
- python3 build.py --distro openshift-enterprise --product "OpenShift Container Platform" --version 4.10 --no-upstream-fetch && python3 makeBuild.py | |||
- python3 build.py --distro openshift-dedicated --product "OpenShift Dedicated" --version 4 --no-upstream-fetch && python3 makeBuild.py | |||
- python3 build.py --distro openshift-rosa --product "Red Hat OpenShift Service on AWS" --version 4 --no-upstream-fetch && python3 makeBuild.py | |||
|
|||
after_success: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might also need to determine what constitutes a success if multiple distro builds are being run. Would one successful build cause the automerge to take place, or would all of the build.py
runs need to succeed? How can we test this in Travis?
@pneedle-rh Maybe we can use a build matrix to run all these test in parallel with multiple jobs? https://docs.travis-ci.com/user/build-matrix/
EDIT: maybe: jobs:
include:
- name: Build openshift-enterprise
- language: python
cache: pip
sudo: required
before_install:
- gem install asciidoctor
- gem install asciidoctor-diagram
install:
- pip3 install pyyaml
- pip3 install aura.tar.gz
script:
- python3 build.py --distro openshift-enterprise --product "OpenShift Container Platform" --version 4.10 --no-upstream-fetch && python3 makeBuild.py
after_success:
- bash ./automerge.sh
- name: Build openshift-dedicated
- language: python
cache: pip
sudo: required
before_install:
- gem install asciidoctor
- gem install asciidoctor-diagram
install:
- pip3 install pyyaml
- pip3 install aura.tar.gz
script:
- python3 build.py --distro openshift-dedicated --product "OpenShift Dedicated" --version 4 --no-upstream-fetch && python3 makeBuild.py
- name: Build openshift-rosa
- language: python
cache: pip
sudo: required
before_install:
- gem install asciidoctor
- gem install asciidoctor-diagram
install:
- pip3 install pyyaml
- pip3 install aura.tar.gz
script:
- python3 build.py --distro openshift-rosa --product "Red Hat OpenShift Service on AWS" --version 4 --no-upstream-fetch && python3 makeBuild.py
|
Created travis-ci/docs-travis-ci-com#3153 to check on the build jobs. Also created a support issue with Travis CI. |
@gaurav-nelson thanks for #40741. That is a much better solution that the one I proposed here, so I am closing this PR as obsoleted by your PR. Thanks again! |
This applies to
main
andenterprise-4.10
. #40592 is a separate PR forenterprise-4.9
.This pull request adds the OSD and ROSA collections to the Travis checks. Related PR #40587 was created to test the checks for the two collections.
The PR also updates the
build.py
script which is called in the.travis.yml
file. The addition cleans thedrupal-build
directory in the Travis VM that is running the checks, rather than just cleaning the distro subdirectory within thedrupal-build
directory. Without this change, each successivepython build.py...
command in thetravis.yml
file will build all of the distros that have been built so far, because the remnants of the previous run continues to exist in thedrupal-build
directory in the Travis VM.My understanding is that in
main
andenterprise-4.10
, thebuild.py
script is only called from the.travis.yml
file. The sync scripts I think use thebuild_for_portal.py
file instead. Please let me know if the change in this PR might impact other uses for thebuild.py
file that I don't know about. I.e. is there any reason why the previous builds for a different distro might need to remain in thedrupal-build
directory after thebuild.py
script has run?We might also need to determine what constitutes a success if multiple distro builds are being run. Would one successful build cause the auto-merge to take place, or would all of the
build.py
runs need to succeed? How can we test this in Travis?