Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do pip install quiet. #810

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

skordas
Copy link
Contributor

@skordas skordas commented Feb 19, 2025

This will still keep it quiet, but throw some information when something goes wrong - and it's look nicer 😄

Copy link

openshift-ci bot commented Feb 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: skordas
Once this PR has been reviewed and has the lgtm label, please assign mffiedler for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@skordas
Copy link
Contributor Author

skordas commented Feb 19, 2025

@qiliRedHat PTAL - I don't want to merge this without your check first.

@qiliRedHat
Copy link
Contributor

@skordas Thanks. Are you using reliabilty-v2 or play with it? I'm just curious why you had the idea to change the code here. Let me do a test to make sure it works well before I approve.

@skordas
Copy link
Contributor Author

skordas commented Feb 28, 2025

Hi @qiliRedHat
This script is used in prow: https://github.com/openshift/release/blob/master/ci-operator/step-registry/openshift/svt/reliability-v2/openshift-svt-reliability-v2-commands.sh
in openshift-svt-master__reliability-v2-aws-4.18-nightly-x86 tests.

I was running this test and was failing without info why...
pip3 install -r requirements.txt > /dev/null 2>&1 is sending everything to /dev/null
and -p flag it's make it nicer 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants