Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update nepali months data #103

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

sajin-shrestha
Copy link
Collaborator

Description

This PR contains the updated month data from 2081 to 2099 based on the data from nepali patro.

Related Issue

#82

Type of Change

Please mark the appropriate option below to describe the type of change your pull request introduces:

  • Bug fix
  • New feature
  • Enhancement
  • Documentation update
  • Refactor
  • Other (please specify)

Checklist

  • I have added/updated the necessary documentation on README.md.
  • I have added appropriate test cases (if applicable) to ensure the changes are functioning correctly.
  • My pull request has a clear title and description.

Additional Notes

[Add any additional notes or context that you think the reviewers should know about.]

By submitting this pull request, I confirm that I have read and complied with the contribution guidelines of this project.

@aj3sh
Copy link
Member

aj3sh commented Dec 22, 2024

Thanks @sajin-shrestha for your contribution. 🙂

@aj3sh aj3sh requested a review from binodnepali December 22, 2024 15:31
@aj3sh
Copy link
Member

aj3sh commented Dec 22, 2024

I checked the data with NepaliPatro, and the PR's data aligns with it. I have also confirmed the year's total days data using the below script:

function arraySum(numbers) {
  return numbers.reduce((sum, num) => sum + num, 0);
}

NP_MONTHS_DATA.forEach((data, i) => {
  if (arraySum(data[0]) !== data[1]) {
    console.log("Wrong Year's total days: " + (2000 + i));
  }
});

@aj3sh aj3sh merged commit b19d135 into opensource-nepal:main Dec 23, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants