Fix migration filename pattern in AppFolderMigrationSource

opensrp · Apr 28, 2021 · b746a45 · b746a45
1 parent 193b5ba
commit b746a45
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/opensrp-app/src/main/java/org/smartregister/AllConstants.java b/opensrp-app/src/main/java/org/smartregister/AllConstants.java
@@ -140,6 +140,7 @@ public class AllConstants {
     public static final String COMBINE_CHECKBOX_OPTION_VALUES = "combine_checkbox_option_values";
 
     public static final String GPS = "gps";
+    public static final String MIGRATION_FILENAME_PATTERN = "(\\d)\\.(up|down)\\.sql";
 
 
     public static class Immunizations {

diff --git a/opensrp-app/src/main/java/org/smartregister/repository/dao/AppFolderMigrationSource.java b/opensrp-app/src/main/java/org/smartregister/repository/dao/AppFolderMigrationSource.java
@@ -5,6 +5,7 @@
 import android.text.TextUtils;
 
 import org.apache.commons.io.FileUtils;
+import org.smartregister.AllConstants;
 import org.smartregister.repository.MigrationImpl;
 import org.smartregister.repository.contract.MigrationSource;
 import org.smartregister.util.Utils;
@@ -41,7 +42,7 @@ public HashMap<Integer, ArrayList<Migration>> getMigrations(int fromDbVersion) {
             File appFolderDirectory = new File(Environment.getDataDirectory(), "/data/" + Utils.getAppId(context) + "/files/migrations");
             String[] migrationFileNames = appFolderDirectory.list();
 
-            String regex = "(/d)/.(up|down)/.sql";
+            String regex = AllConstants.MIGRATION_FILENAME_PATTERN;
             Pattern filePattern  = Pattern.compile(regex);
 
             if (migrationFileNames != null) {

diff --git a/opensrp-app/src/main/java/org/smartregister/repository/dao/AssetMigrationSource.java b/opensrp-app/src/main/java/org/smartregister/repository/dao/AssetMigrationSource.java
@@ -3,6 +3,7 @@
 import android.content.Context;
 import android.text.TextUtils;
 
+import org.smartregister.AllConstants;
 import org.smartregister.repository.MigrationImpl;
 import org.smartregister.repository.contract.MigrationSource;
 import org.smartregister.util.AssetHandler;
@@ -37,7 +38,7 @@ public HashMap<Integer, ArrayList<Migration>> getMigrations(int fromDbVersion) {
         try {
             String[] migrationFileNames = context.getAssets().list("config/migrations");
 
-            String regex = "(\\d)\\.(up|down)\\.sql";
+            String regex = AllConstants.MIGRATION_FILENAME_PATTERN;
             Pattern filePattern  = Pattern.compile(regex);
 
             if (migrationFileNames != null) {