Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encrypt Shared Preferences #688

Merged
merged 24 commits into from
Feb 9, 2021
Merged

Encrypt Shared Preferences #688

merged 24 commits into from
Feb 9, 2021

Conversation

qiarie
Copy link
Contributor

@qiarie qiarie commented Nov 12, 2020

  • Add option to encrypt SharedPreferences
  • Add support for migration of existing installs

@qiarie qiarie requested review from githengi and ndegwamartin and removed request for githengi November 12, 2020 09:57
@ndegwamartin ndegwamartin force-pushed the encrypt-shared-preferences branch from fca486c to 8e16d11 Compare November 17, 2020 06:32
@qiarie qiarie force-pushed the encrypt-shared-preferences branch from 8e16d11 to 25f561b Compare November 18, 2020 10:28
@qiarie qiarie marked this pull request as ready for review November 18, 2020 10:29
@coveralls
Copy link

coveralls commented Nov 18, 2020

Coverage Status

Coverage decreased (-0.07%) to 66.752% when pulling a1e7d1e on encrypt-shared-preferences into b78069d on master.

@qiarie qiarie force-pushed the encrypt-shared-preferences branch 2 times, most recently from 0871257 to 7852ba9 Compare November 19, 2020 10:21
@qiarie qiarie requested a review from githengi November 20, 2020 07:31
@qiarie qiarie force-pushed the encrypt-shared-preferences branch from f4dba47 to 592601f Compare November 26, 2020 10:44
@ndegwamartin ndegwamartin requested a review from Andati December 7, 2020 11:48
@qiarie qiarie force-pushed the encrypt-shared-preferences branch 2 times, most recently from dddca6c to 5a13930 Compare December 7, 2020 12:56
Andati
Andati previously approved these changes Dec 7, 2020
@ndegwamartin
Copy link
Contributor

@qiarie We'll need to add support for migration of existing installs. Check out the issue #719

@ndegwamartin ndegwamartin force-pushed the encrypt-shared-preferences branch 2 times, most recently from 2158242 to f396f29 Compare December 14, 2020 09:13
@qiarie qiarie force-pushed the encrypt-shared-preferences branch 2 times, most recently from b2e0c23 to 6ff900c Compare January 15, 2021 14:05
ndegwamartin
ndegwamartin previously approved these changes Jan 15, 2021
@qiarie qiarie force-pushed the encrypt-shared-preferences branch from 6ff900c to 79076f4 Compare February 2, 2021 05:55
@qiarie qiarie closed this Feb 2, 2021
@qiarie qiarie reopened this Feb 2, 2021
@qiarie qiarie force-pushed the encrypt-shared-preferences branch from 79076f4 to 3f8a56f Compare February 2, 2021 11:34
- Update minimum SDK to 23
- Update SharedPrefences dependency to androidx.preferences
@qiarie qiarie force-pushed the encrypt-shared-preferences branch from 2af44c8 to b93a52f Compare February 9, 2021 07:06
@qiarie qiarie merged commit 4dae553 into master Feb 9, 2021
@qiarie qiarie deleted the encrypt-shared-preferences branch February 9, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants