OptiBP Widget #581
Merged
OptiBP Widget #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m into feature/optibp-widget
jcenter() is at end of life but we still need it to resolve rdt-capture & circle progressbar libs
dubdabasoduba
requested changes
May 25, 2021
...oid-json-form-wizard/src/main/java/com/vijay/jsonwizard/utils/JsonFormMLSAssetGenerator.java
Show resolved
Hide resolved
gradle.properties
Outdated
| @@ -1,4 +1,4 @@ | |||
| VERSION_NAME=2.0.11-SNAPSHOT | |||
| VERSION_NAME=2.1.1-SNAPSHOT | |||
There was a problem hiding this comment.
Why are we jumping to 2.1.1 instead of 2.1.0?
There was a problem hiding this comment.
Reverted to v2.1.0
allan-on
reviewed
May 25, 2021
| public static final int OPTIBP_REPEAT_REQUEST_CODE = 302; | ||
| public static final String OPTIBP_REPORT_RESULT = "result"; | ||
| public static final String OPTIBP_REPORT_COMPONENT = "component"; | ||
| public static final String OPTIBP_REPORT_VALUE_QUANITITY = "valueQuantity"; |
There was a problem hiding this comment.
There's a tiny typo here -> VALUE_QUANTITY
There was a problem hiding this comment.
Yes, I updated some functionality in NativeRadioButtonFactory and CheckBoxFactory to fix a FATAL EXCEPTION appearing on Android 7, resulting in failing tests for these 2. So after that, I also had to update tests for these.
dubdabasoduba
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #570