🚧 workflow pause monitors #1159
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Deploying openstatus-docs with
|
| Latest commit: |
cae2930
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ada21447.openstatus-1sy.pages.dev |
| Branch Preview URL: | https://workflow-monitor.openstatus-1sy.pages.dev |
There was a problem hiding this comment.
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- apps/workflows/package.json: Language not supported
Comments suppressed due to low confidence (3)
apps/workflows/src/cron/monitor.ts:55
- [nitpick] The variable 'user' is being redeclared within the loop, which could lead to confusion. It should be renamed to avoid ambiguity.
for (const user of users) {
apps/workflows/src/cron/monitor.ts:75
- The 'CreateTask' function is called without awaiting its result. This could lead to unexpected behavior if the task creation fails or takes longer than expected.
await CreateTask({
apps/workflows/src/cron/monitor.ts:135
- The 'timestamp' variable is calculated but not used correctly in the 'scheduleTime' object. It should be converted to an integer.
const timestamp = Date.now();
| // | ||
| // Start workflow -> create task with monitors/start | ||
| // add users to workflow Redis | ||
| console.log(`user worflow started for ${user.userId}`); |
There was a problem hiding this comment.
The log message contains a typo. It should be 'workflow' instead of 'worflow'.
| console.log(`user worflow started for ${user.userId}`); | |
| console.log(`user workflow started for ${user.userId}`); |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
| client: CloudTasksClient; | ||
| step: z.infer<typeof workflowStepSchema>; | ||
| }) { | ||
| const url = ""; |
There was a problem hiding this comment.
The 'url' variable is declared but not assigned any value, which will cause the task creation to fail.
| const url = ""; | |
| const url = `${env().API_BASE_URL}/tasks/${step}`; |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Pause monitors for free users
Still a WIP