New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed-KartaView-Filtering-by-date-removes-sequence-line #10718

Open

draunger wants to merge 2 commits into openstreetmap:develop from draunger:Filtering-by-date-removes-sequence-line

+79 −35

Contributor

draunger commented Jan 29, 2025 •

edited

Loading

description:

fixes the removal of sequence line on filtering the dates on kartaview

problem before:

Sequence lines were not rendering correctly
Filters were too strict
Data validation was minimal
Many valid sequences were being hidden

In kartaview.js file:

Implemented robust image validation
Added checks for:
Sequence existence
Image location completeness
-Coordinate validity

In kartaview_images.js file:

Modified filtering logic
Implemented more flexible sequence acceptance
Added comprehensive validation checks

solves:

draunger added 2 commits

January 29, 2025 19:34


          fixed-KartaView-Filtering-by-date-removes-sequence-line

2ea27b5


          testcase corrected

79bf758

Contributor Author

draunger commented Jan 30, 2025

hey @tyrasd can you review my PR if you seem any issue you can tell me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet