Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support multiple prerequisiteTags for presets #9511

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

support multiple prerequisiteTags for presets #9511

wants to merge 1 commit into from
+7 −1

Conversation

k-yle
Copy link
Collaborator

@k-yle k-yle commented Feb 26, 2023 •
edited
Loading

schema-builder only allows you to define one prerequisiteTag per preset. This PR, along with ideditor/schema-builder#87, changes the format to allow multiple possible values.

@k-yle k-yle mentioned this pull request Feb 26, 2023
Open
@tyrasd tyrasd added the preset An issue with an OpenStreetMap preset or tag label Mar 3, 2023
@tyrasd tyrasd added this to the 2.26 milestone Mar 3, 2023
tyrasd
tyrasd approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have an example field in mind, where this functionality would be useful?

I'm asking myself if we could need a similar extension also for valueNot as well?!

@k-yle
Copy link
Collaborator Author

k-yle commented Mar 3, 2023

The case I had in mind was seamark:bridge:clearance_height, seamark:bridge:clearance_height_open, etc. where the tag(s) depend on the type of bridge.

the electrified tag on railways already gets around this limitation by using valueNot no for voltage

another thought I had, but this could be a future PR: It would be nice to support regexs, so that seamark:*:colour_pattern only shows up if seamark:*:colour contains multiple colours (i.e. the :colour field contains a ;)

@tyrasd tyrasd modified the milestones: 2.26, 2.27 May 26, 2023
@tyrasd tyrasd modified the milestones: 2.27, 2.29 Feb 28, 2024
@k-yle k-yle force-pushed the multiple-prerequisiteTag branch from c95d270 to 97b85b5 Compare May 25, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyrasd tyrasd tyrasd approved these changes

Assignees
No one assigned
Labels
preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Milestone
2.29
Development

Successfully merging this pull request may close these issues.
2 participants
@k-yle @tyrasd