Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amenity=charging_station: add field for supported vehicles #1106

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

qugebert
Copy link
Contributor

@qugebert qugebert commented Feb 7, 2024

This is the first part of #1085

I used the list of possible vehicles from https://wiki.openstreetmap.org/wiki/Tag:amenity%3Dcharging_station#Vehicles

Copy link

github-actions bot commented Feb 7, 2024

🍱 You can preview the tagging presets of this pull request here.

data/fields/electric_vehicle.json Outdated Show resolved Hide resolved
"motorcycle": "Motorcycles",
"hgv": "Trucks",
"bus": "Buses",
"small_electric_vehicle": "Small electric vehicles"
Copy link
Contributor

@1ec5 1ec5 Feb 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a tricky one to word in American English (the default locale): “small electric vehicles” is a legal term in “many European countries”, but to an American it would sound like a description of, say, a Smart car or golf cart, because things the size of a bicycle are usually called “devices” rather than “vehicles” here.

Also, this PR translates hgv as “trucks” rather than “heavy goods vehicles”, the UK legal term, which I agree with, but it makes the user even less likely to notice that “small electric vehicles” is a legal term.

Assuming it’s OK to use this value even in the U.S., consider either “personal mobility devices” or “micromobility devices”. These terms can also apply to unpowered devices like kick scooters, but I don’t think we need to be concerned about that ambiguity in the context of this field.

Regardless, this string should be in Title Case.

Copy link
Contributor Author

@qugebert qugebert Feb 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your feedback. It's sometimes hard for me as a non-native-speaker to find the correct wordings.

I had another look to the wiki and now i'm even more confused than before.
Whilst in the vehicles-section the tagging small_electric_vehicles=yes is used, the tagging scooter=yes is used in the examples-section (and in the german wiki page).
And for trucks, the english wiki says hgv=yes whilst the german wiki says truck=yes

Should i omit these two from the list as there is a quite low usage anyway or should we try to get a clarification for a unique tagging from the community forum?

Thank you also for the hint to "Title Case" convention.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that is confusing! A discussion in the forum would be a good idea, just to be on the safe side and raise awareness.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't care about the German Wiki. The quoted information is from the first version of the article from 10 years ago and was no longer up to date. I have just updated the wiki at this point. The term "scooter" in OSM refers to more "moped" like vehicles (which is also how it was written in the translation) rather than "kick scooters" (which are small_electric_vehicles if equipped with an electric motor). truck should explicitly not be used and replaced with hgv.

Copy link
Member

@tyrasd tyrasd Feb 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

personal mobility device

I think this term might be easily confused with personal mobility aid devices (i.e. "fancy" electric wheelchairs), which are AFAIK are not meant to be included in this tag.

The wiki uses "Electric scooter" as a description for the small_electric_vehicle tag. Maybe that's good enough, especially if we're also thinking about simplifying hgv to Truck?!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants