-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce bicycle_road presets with special access field #1207
base: main
Are you sure you want to change the base?
Conversation
🍱 You can preview the tagging presets of this pull request here. |
data/fields/access_vehicle.json
Outdated
@@ -0,0 +1,23 @@ | |||
{ | |||
"key": "vehicle", | |||
"type": "defaultCheck", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be a dropdown. The values can be "no", "yes", "destination"
This requires to remove the "copy fields from parent" in order to remove the original `access` field
Documenting Test 2This is the version with a copy of the access field. This version requires to duplicate the I still don't like how hidden the difference between I consider this Test 2 a much better result than Test 1. |
TestingThere is a bug when changing an existing way to one of those presets. It looks like the highway tags get removed so the style and preset break. – Need to create a propper test case. |
TestingNeed to look into making this preset country specific, so moving |
@olafkryus after your successful #1384 maybe you are interested in helping getting this of the ground :) |
Ping #1013
vehicle
case – See todos.--
This is a draft for now until I had time to test it in the preview.
--
Other todos
cyclestreet-BE-NL
needs further consideration…vehicle
to the list.fields/access
to allow optional otheraccess:*
tags #1208