Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add #[precompile::view] attribute to getTotalColdkeyStake and getTotalHotkeyStake #1346

Open
wants to merge 4 commits into
base: devnet-ready
Choose a base branch
from
Open

Add #[precompile::view] attribute to getTotalColdkeyStake and getTotalHotkeyStake #1346

wants to merge 4 commits into from
+3 −1

Conversation

Shr1ftyy
Copy link

  • added view attribute to getTotalColdkeyStake and getTotalHotkeyStake functions

Description

These functions in the staking precompile (which I added, and also got recently merged in 😭) cannot be called from within static contexts (i.e. view and pure) functions, even though they do not actually modify state. This PR addresses this issue.

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

sam0x17 and others added 2 commits February 24, 2025 14:40
@sam0x17 @unconst
@camfairchild @gztensor @qxprakash @open-junius @ibraheem-opentensor @ales-otf @JohnReedV
mainnet deploy 2/24/2025 (opentensor#1340)
5073ade 
* fix migration test

* cargo fmt

* fix root

* cargo fmt

* add moving price to metagraph

* use correct min burn init (opentensor#1265)

* use correct min brun init

* fmt

* no into

* no into 2

* bump spec

* cargo update to fix cargo audit vulnerabilities

* bump spec version

* moving price init from emission

* cargo fmt

* bump spec version

* commit Cargo.lock

* cargo clippy

* cargo fmt

* DefaultMinimumPoolLiquidity and tempos in rao migration

* update readme of support of M series macs

* bump runtime version

* add tao_emission to stakeinfo runtime

* Refactor staking and neuron precompile with precompile-utils

* remove call from coinbase. already in block_step

* add negation for pow-reg-allowed

* only root can set min pow diff

* oops

* dont let ck-in-swap-sched move any stake/register

* add tests for validation filter

* add transfer stake to call nontransfer proxy filter

* also add proxy filters for new calls

* update staking priority

* bump spec

* use get_priority_staking for all stake operations

* bump spec

* clippy

* Remove ownership check from transition stake validation

* Fix number conversion issues in staking precompile

* max the price for EMA calc at 1.0

* uncommitted lockfile change

* bump spec version

* fix merge conflicts

* add CI action that requires clean merges between all named branches

* Refactor neuron precompil
- introduce PrecompileHandle and Precompile trait extensions

* fix

* fixes

* try again

* fix again

* fix

* fix

* stop needless wasting of CI hours with on push triggers we don't need

* Refactor metagraph precompile

* fix try runtime endpoints

* fix

* provide an identity for github action to prevent failure

* bump CI

* only run non-devnet try runtime if we are targeting devnet/testnet/main

* tweak

* Add serve_axon extrinsic validation

* Bump spec version

* Check IP validity in serve_axon validation first

* make set diff only root

* add test for set diff no owner

* add migration for min diff

* bump spec

* only allow top-stake SN owner hk to stay immune

* add tests

* only allow replace non-top-stake owner hk

* bump spec

* add tests using SubnetOwnerHotkey

* add impl for replace neuron

* add swap test

* add neuron prune impl

* add swap hotkey impl

* clippy

* clippy

* mistake in test

* add some tests

* add stake ext test

* add move_stake tests

* cargo lock

* bump spec

* clpy

* use bool return type

* clpy

* add higher liquidity on mvoe stake tests

* Refactor subnet precompile

* Reformat

* Update spec version

* Fix commit_hash type in Neuron::commit_weights precompile

* Prevent precision errors in share pool

* Fix unstaking 99.999% and add tests

* Fix event and logging in unstake_from_subnet

* only update tx rate limit *after* ensure

* add test and sn-owner-chk impl

* Fix build

* use is ok and

* Bump spec version

* Update primitives/share-pool/src/lib.rs

Co-authored-by: Cameron Fairchild <[email protected]>

* Update pallets/subtensor/src/tests/staking.rs

Co-authored-by: Cameron Fairchild <[email protected]>

* Remove unused variable

* Add test_get_shares_per_update

* try it again

* use latest rust-cache version

* improve spec version check cache performance

* try busting cache

* it worked 🔥

* use better rust cache throughout CI + clean up CI

* install rust nightly for cargo fmt

* whoops

* fix

* try re-enabling finney try truntime

* Update pallets/subtensor/src/tests/staking.rs

Co-authored-by: Cameron Fairchild <[email protected]>

* fix

* add get value using current_shares arg

* make delegate info useful again

* return different format for get delegated

* remove CODEOWNERS file so we can do green merges

* bump CI

* Set initial tempo to 360

* set equal in mock

* add test for weights rate limit v tempo

* make fields pub for testing

* sub out root divs to get alpha divs

* bump spec version to 241

* const fixes

* cargo clippy

* Add dest hotkey check and test

* Remove the commented test

* Bump spec version

* use rust 1.85.0

* upgrade to Rust 2024 Edition 🎉

* whitelist clippy useless conversion warning

* cargo fmt

* passes clippy

* Remove in/out peers args from docker compose

* fix test

* Update chainspecs

* Remove Stake map - in progress (tests broken)

* become delegate on every add_stake op

* bump spec

* Fix tests

* Fix clippy

* add root set sn moving alpha

* fmt

* fix test

* fixes GH opentensor#1330

* bump spec

* add a rate limit-set on decrease take (avoids close increase)

* add test

* add call to associate hk

* update comment from PR1335

* bump spec version

---------

Co-authored-by: unconst <[email protected]>
Co-authored-by: Unconst <[email protected]>
Co-authored-by: Cameron Fairchild <[email protected]>
Co-authored-by: Greg Zaitsev <[email protected]>
Co-authored-by: Prakash <[email protected]>
Co-authored-by: open-junius <[email protected]>
Co-authored-by: ibraheem-opentensor <[email protected]>
Co-authored-by: Aliaksandr Tsurko <[email protected]>
Co-authored-by: John Reed <[email protected]>
Co-authored-by: camfairchild <[email protected]>
Co-authored-by: gztensor <[email protected]>
Co-authored-by: camfairchild <[email protected]>
@Shr1ftyy
feat: add view attribute
5b7c293 
- added view attribute to getTotalColdkeyStake and getTotalHotkeyStake functions
@Shr1ftyy Shr1ftyy marked this pull request as draft February 27, 2025 07:11
@Shr1ftyy Shr1ftyy marked this pull request as ready for review February 27, 2025 07:29
@sam0x17
Copy link
Contributor

sam0x17 commented Feb 27, 2025

can you please merge latest devnet-ready into your branch? that should appease CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camfairchild camfairchild camfairchild approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shr1ftyy @sam0x17 @camfairchild