Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[telemetry] add proto for DHCPv6 PD metrics #2110

Merged
merged 2 commits into from
Dec 28, 2023
Merged

[telemetry] add proto for DHCPv6 PD metrics #2110

merged 2 commits into from
Dec 28, 2023

Conversation

sherysheng
Copy link
Contributor

erjiaqing
erjiaqing reviewed Nov 30, 2023
View reviewed changes
src/proto/thread_telemetry.proto Outdated Show resolved Hide resolved
src/utils/thread_helper.cpp Show resolved Hide resolved
@sherysheng sherysheng requested a review from erjiaqing December 1, 2023 09:55
@sherysheng sherysheng changed the title [Telemetry] Add proto for PD metrics [telemetry] add proto for DHCPv6 PD metrics Dec 4, 2023
superwhd
superwhd reviewed Dec 4, 2023
View reviewed changes
Copy link
Contributor

@superwhd superwhd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC Depends-On only works in openthread repo.

src/utils/thread_helper.cpp Outdated Show resolved Hide resolved
src/utils/thread_helper.cpp Outdated Show resolved Hide resolved
third_party/openthread/repo Outdated Show resolved Hide resolved
@sherysheng
Copy link
Contributor Author

Depends-On: openthread/openthread#9645

The Dependency has been merged, so the sumodule commit has been removed now

@sherysheng sherysheng force-pushed the pdp branch 2 times, most recently from e437806 to 65dbe52 Compare December 5, 2023 07:28
Irving-cl
Irving-cl approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@Irving-cl Irving-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

morningboata
morningboata reviewed Dec 5, 2023
View reviewed changes
src/utils/thread_helper.cpp Outdated Show resolved Hide resolved
src/utils/thread_helper.cpp Show resolved Hide resolved
superwhd
superwhd reviewed Dec 6, 2023
View reviewed changes
src/utils/thread_helper.cpp Outdated Show resolved Hide resolved
src/utils/thread_helper.cpp Outdated Show resolved Hide resolved
src/utils/thread_helper.cpp Outdated Show resolved Hide resolved
abtink
abtink reviewed Dec 7, 2023
View reviewed changes
src/utils/thread_helper.cpp Outdated Show resolved Hide resolved
src/utils/thread_helper.cpp Outdated Show resolved Hide resolved
@sherysheng sherysheng requested a review from abtink December 7, 2023 14:34
superwhd
superwhd reviewed Dec 8, 2023
View reviewed changes
src/utils/thread_helper.cpp Show resolved Hide resolved
src/utils/thread_helper.cpp Outdated Show resolved Hide resolved
src/utils/thread_helper.hpp Outdated Show resolved Hide resolved
src/utils/thread_helper.cpp Outdated Show resolved Hide resolved
@sherysheng sherysheng requested a review from superwhd December 8, 2023 06:10
superwhd
superwhd approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@superwhd superwhd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit.

src/utils/thread_helper.cpp Outdated Show resolved Hide resolved
@sherysheng sherysheng force-pushed the pdp branch 2 times, most recently from 160933e to 25bfc09 Compare December 8, 2023 06:31
erjiaqing
erjiaqing reviewed Dec 13, 2023
View reviewed changes
script/test Outdated Show resolved Hide resolved
@sherysheng sherysheng force-pushed the pdp branch 2 times, most recently from 65ce7ec to 1fd58a8 Compare December 13, 2023 07:27
abtink
abtink approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@abtink abtink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Couple of smaller suggestions below.

src/utils/thread_helper.cpp Outdated Show resolved Hide resolved
src/utils/thread_helper.cpp Outdated Show resolved Hide resolved
@sherysheng sherysheng force-pushed the pdp branch 2 times, most recently from 15d3ede to 1ecafe9 Compare December 14, 2023 10:24
@sherysheng sherysheng requested a review from jwhui December 18, 2023 06:45
jwhui
jwhui reviewed Dec 18, 2023
View reviewed changes
src/proto/thread_telemetry.proto Outdated Show resolved Hide resolved
src/utils/thread_helper.cpp Outdated Show resolved Hide resolved
@jwhui jwhui merged commit 86f6fb2 into openthread:main Dec 28, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erjiaqing erjiaqing erjiaqing approved these changes

@morningboata morningboata morningboata approved these changes

@abtink abtink abtink approved these changes

@jwhui jwhui jwhui approved these changes

@Irving-cl Irving-cl Irving-cl approved these changes

@superwhd superwhd superwhd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sherysheng @erjiaqing @superwhd @Irving-cl @jwhui @abtink @morningboata