Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dbus] simplify getting OT instance in dbus RCP thread object #2660

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

Irving-cl
Copy link
Contributor

This PR simplifies the way to get OT instance in DbusThreadObjectRcp.

Copy link
Contributor

@zhanglongxia zhanglongxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 43.64%. Comparing base (2b41187) to head (05ee60a).
Report is 910 commits behind head on main.

Files with missing lines Patch % Lines
src/dbus/server/dbus_thread_object_rcp.cpp 0.00% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2660       +/-   ##
===========================================
- Coverage   55.77%   43.64%   -12.13%     
===========================================
  Files          87      106       +19     
  Lines        6890    13254     +6364     
  Branches        0      953      +953     
===========================================
+ Hits         3843     5785     +1942     
- Misses       3047     7163     +4116     
- Partials        0      306      +306     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Irving-cl Irving-cl requested a review from jwhui January 6, 2025 11:52
@jwhui jwhui merged commit a716787 into openthread:main Jan 6, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants