[nrf528xx] clear psdu_being_received in CRCOK handler #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flag psdu_being_received is set to True when the radio driver receives the FCF field of the data frame, and the flag will be cleared after the ACK is sent out if the ACK is required. Sometimes, the ACK is failed to be sent out, which causes the flag to be set to True forever. Then the radio driver can't send out any frames. The sdk-nrfxlib (https://github.com/nrfconnect/sdk-nrfxlib/blob/main/nrf_802154/driver/src/nrf_802154_trx.c#L2492) clears the flag `psdu_being_received` in the CRCOK handler. This commit clears the flag `psdu_being_received` when the irq_crcok_state_rx() is handled. Ref: https://nrfsupport.atlassian.net/browse/NRF11-73
edmont
approved these changes
Apr 9, 2024
jwhui
approved these changes
Apr 9, 2024
jwhui
changed the title
jwhui
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flag
psdu_being_receivedis set to True when the radio driver receives the FC field of the data frame, and the flag will be cleared after the ACK is sent out in PHYEND handler if the ACK is required. Sometimes, the ACK is failed to be sent out, which causes the flag to be set to True forever. Then the radio driver can't send out any frames.The sdk-nrfxlib (https://github.com/nrfconnect/sdk-nrfxlib/blob/main/nrf_802154/driver/src/nrf_802154_trx.c#L2492) clears the flag
psdu_being_receivedin the CRCOK handler rather than PHYEND handler. This commit clears the flagpsdu_being_receivedin CRCOK handler to avoid thepsdu_being_receivedbeing permanently set to True.Issue link: https://nrfsupport.atlassian.net/browse/NRF11-73