Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): User feedback: When the Modal is closed after a user switches to another page, the close event is triggered by mistake. #1481

Closed

Conversation

James-9696
Copy link
Collaborator

@James-9696 James-9696 commented Mar 12, 2024

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

vercel bot commented Mar 12, 2024

@James-9696 is attempting to deploy a commit to the OpenTiny Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

[e2e-test-warn]
The component to be tested is missing.

The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug".

Please make sure you've read our contributing guide

@James-9696 James-9696 changed the title fix: 用户反馈问题:直接切换路由跳转页面,Modal关闭时错误触发close事件 bug(modal): User feedback: When the Modal is closed after a user switches to another page, the close event is triggered by mistake. Mar 12, 2024
@James-9696 James-9696 changed the title bug(modal): User feedback: When the Modal is closed after a user switches to another page, the close event is triggered by mistake. fix(modal): User feedback: When the Modal is closed after a user switches to another page, the close event is triggered by mistake. Mar 12, 2024
@James-9696 James-9696 closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant