feat: add next/cloud-icons project #2821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThis pull request introduces a comprehensive set of changes focused on cloud icons, internationalization, and project configuration. The modifications span multiple files across different directories, including the addition of a new cloud icons library, updates to internationalization support with Spanish and Portuguese languages, and modifications to Changes
Sequence DiagramsequenceDiagram
participant User
participant IconInterface
participant IconRenderer
participant IconSet
User->>IconInterface: Select Category
User->>IconInterface: Choose Color
IconInterface->>IconRenderer: Trigger Render
IconRenderer->>IconSet: Fetch Icons
IconRenderer-->>IconInterface: Display Icons
User->>IconInterface: Copy Icon HTML
IconInterface->>Clipboard: Copy Icon Representation
Possibly related PRs
Suggested labels
Poem
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
[e2e-test-warn] The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug". Please make sure you've read our contributing guide |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 9
🧹 Nitpick comments (8)
examples/sites/demos/pc/app/pop-upload/file-type.spec.ts (1)
14-17: Consider using import statement instead of require.The
requirestatement triggers an eslint warning. Consider using the ES6 import syntax if possible.- // eslint-disable-next-line @typescript-eslint/no-require-imports, @typescript-eslint/no-var-requires - const path = require('node:path') + import * as path from 'node:path'examples/sites/demos/pc/webdoc/i18n-en.md (1)
134-134: Consider implications of changing default locale.The example sets Spanish (
esLA) as the default locale, which might not be the best choice for documentation examples. Consider keeping Chinese or English as the default for consistency with earlier examples.- export const i18n = initI18n({ locale: 'esLA' }) + export const i18n = initI18n({ locale: 'zhCN' })examples/sites/demos/pc/webdoc/i18n.md (1)
181-219: LGTM! Documentation is consistent across languages.The Chinese documentation perfectly mirrors the English version, maintaining consistency in:
- Structure and content
- Code examples
- Version requirements
However, the same concern about the default locale applies here as in the English version.
- export const i18n = initI18n({ locale: 'esLA' }) // 此处指定初始的默认语言 + export const i18n = initI18n({ locale: 'zhCN' }) // 此处指定初始的默认语言next/cloud-icons/scripts/__tests__/build.test.ts (1)
4-13: Enhance test coverage for path parsing.The current test only covers a happy path scenario. Consider adding tests for:
- Invalid path formats
- Missing order numbers
- Special characters in names
- Empty group names
+test('测试解析路径的错误情况', () => { + expect(() => parsePath('./invalid/path.svg')).toThrow() + expect(() => parsePath('./svgs/base/方向/no-order-go.svg')).toThrow() + expect(() => parsePath('./svgs/base/1-方向/1#特殊!符号-special.svg')).toThrow() +})next/cloud-icons/main.ts (1)
32-54: Optimize performance of icon rendering.The current implementation rebuilds HTML strings in memory. Consider using DocumentFragment for better performance.
- let html = '' + const fragment = document.createDocumentFragment() Object.keys(icons) .sort((groupName1, groupName2) => { const num1 = parseInt(groupName1.split('-')[0]) const num2 = parseInt(groupName2.split('-')[0]) return num1 > num2 ? 1 : -1 }) .forEach((groupName) => { - html += `<h3 class='icons-group'>${groupName}</h3>` + const group = document.createElement('h3') + group.className = 'icons-group' + group.textContent = groupName + fragment.appendChild(group) }) - list.innerHTML = html + list.replaceChildren(fragment)next/cloud-icons/README.md (2)
10-13: Add language specification to code block.Specify the language for the code block to enable syntax highlighting.
-``` +```bash npm install @opentiny/cloud-icons<details> <summary>🧰 Tools</summary> <details> <summary>🪛 Markdownlint (0.37.0)</summary> 10-10: null Fenced code blocks should have a language specified (MD040, fenced-code-language) </details> </details> --- `1-80`: **Add version compatibility information.** The README should specify: - Supported browser versions - Required Node.js version - Framework compatibility matrix <details> <summary>🧰 Tools</summary> <details> <summary>🪛 Markdownlint (0.37.0)</summary> 10-10: null Fenced code blocks should have a language specified (MD040, fenced-code-language) </details> </details> </blockquote></details> <details> <summary>next/cloud-icons/index.html (1)</summary><blockquote> `7-85`: **Move styles to external stylesheet and improve CSS maintainability.** Consider the following improvements: 1. Move embedded styles to the external stylesheet (`style/all.css`) 2. Use CSS variables for colors and spacing 3. Combine duplicate selectors (lines 69-74) Example refactor: ```diff +/* In style/all.css */ +:root { + --color-primary: #0057c3; + --color-text: #575d6c; + --spacing-base: 8px; +} .icon-counts { - color: #0057c3; + color: var(--color-primary); } -/* Remove duplicate selector */ -.settings label { - margin: 0 16px 12px; -} -.settings label { - font-weight: bold; +.settings label { + margin: 0 calc(var(--spacing-base) * 2) calc(var(--spacing-base) * 1.5); + font-weight: bold; }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (287)
next/cloud-icons/scripts/__tests__/__snapshots__/build.test.ts.snapis excluded by!**/*.snapnext/cloud-icons/scripts/__tests__/函数工作流-FunctionGraph.svgis excluded by!**/*.svgnext/cloud-icons/scripts/__tests__/点击-click.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/1#首页_房子-home.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/10#符号-at.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/100#历史数据-history.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/101#加号_创建-plus.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/102#加号_创建-plus1.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/103#减号_删减-minus1.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/104#更多-more.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/105#更多_3点-more1.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/106#移动_6点_骰子_盲文-dot6.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/11#最新动态_纸飞机-news.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/12#笑脸_满意度评价-smile-face.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/13#最小化-minimize.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/13.1#最大化-maximize.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/14#分享-share.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/15#搜索-search.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/2#短信-email.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/20#通话-call.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/200#加载-loading.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/21#手机-phone.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/22#打印-print.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/23#计算器-calculator.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/24#地图_位置-map.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/25#钥匙_密钥-key.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/26#钥匙_密钥-key1.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/27#相机_拍照-camera.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/28#自动保存-auto-save.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/29#视频-video.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/3#发布-release.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/30#录制-record.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/31#电视_演示-TV.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/32#药箱_诊断-diagnosis.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/33#皮肤_衣服-skin.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/34#告警灯-alarm.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/35#提醒-remind.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/36#定位-position.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/4#消息-message.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/40#投屏-cast.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/41#插头_扩展-plug.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/42#灯泡_想法-idea.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/43#正方体-cube.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/44#麦克风_公告-speeker.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/45#清除-clean.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/46#拖动手形-choose-drag.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/47#点击手形-click.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/48#拖动中手形-choosing.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/49#设置_齿轮-setting.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/5#日期-date.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/50#修复-repair.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/6#书签-bookmark.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/60#置顶_顶部-top.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/61#推荐_喜欢-like.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/62#店铺-shop.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/63#购物车-cart.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/64#售罄-soldout.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/65#手提包_商品-bag.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/66#钱包-wallet.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/67#礼包-gift.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/68#支付_续费-payment.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/69#vscode-vscode.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/7#指南-guide.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/70#助手-assistant.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/71#转码-transcode.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/72#指示器-Indicator .svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/73#堆叠_图层-stack.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/74#日出_唤醒-sun-raise.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/75#太阳_亮色模式-sun.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/76#休眠_月亮-hibernate.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/77#暗色模式_月亮-dark.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/78#对比度_昼夜-contrast.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/79#垂直镜像_对称-mirror-y.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/8#标签-tag.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/80#水平镜像_对称-mirror-x.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/81#对号_选中-tick.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/82#清除_叉号-clear.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/83#箭头右-right.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/84#箭头左-left.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/85#箭头下-down.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/86#箭头上-up.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/87#全部收起-collapse.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/88#全部收起-collapse1.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/89#全部展开-expand.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/9#图钉_固定-pin.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/9.1#取消固定-unpin.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/90#全部展开-expand1.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/91#双箭头左-dbl-left.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/92#双箭头右-dbl-right.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/93#选择-check.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/94#关闭-close.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/95#警告-warn.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/95.1#风险_警告-risk.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/96#版本信息-info.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/97#帮助-help.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/98#停止_禁用-disabled.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/1-标记(Signs)/99#时间-time.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/1#开始-start.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/10#取消收藏_星星-unstar.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/11#半星_半分-half-star.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/12#横向调整-adjust-x.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/13#竖向调整-adjust-y.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/14#筛选-filter.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/15#剪切_裁剪-crop.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/16#返回-backward.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/17#前进-forward.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/2#暂停-pause.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/20#放大-zoom-in.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/21#缩小-zoom-out.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/23#取消隐藏-unhide.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/24#隐藏-hide.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/25#音量-volume.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/26#静音-mute.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/27#横向伸缩-horizontal-scale.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/28#全屏-full.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/29#退出全屏-exit-full.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/3#停止-stop.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/30#全屏_最大化-full1.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/31#退出全屏_还原-exit-full1.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/32#适应画布-fit-canvas.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/33#减号_收起列表-minus-square.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/34#加号_展开列表-plus-square.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/4#播放-start1.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/40#复制-copy.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/41#复制-copy1.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/42#类型-type.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/43#群组_复制-group.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/44#列表_清单-list.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/45#均衡器_配置-custom.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/46#配置-config-x.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/47#配置-config-y.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/48#切换方式-switch.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/49#退出-logout.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/5#暂停-pause1.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/50#登录-login.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/51#退出-logout1.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/52#离开-leave.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/6#降序-desc.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/60#上传-upload.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/61#下载-download.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/62#上传下载-two-way-load.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/63#上传到云-upload-cloud.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/64#选中-choose.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/65#删除-delete.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/66#剪切_剪刀-cut.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/7#升序-asc.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/70#关机-shutdown.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/71#关机-shutdown1.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/72#重启-restart.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/73#重试-retry.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/74#刷新-refresh.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/75#重置密码-reset-pwd.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/76#暂停刷新-pause-refresh.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/77#屏蔽设置_禁止配置-no-setting.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/78#升级-update.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/79#锁-lock-ring.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/8#排序-sort.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/80#解锁-unlock.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/81#锁定-lock.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/82#边界_规则-border.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/83#隐藏边界_规则-dash-border.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/2-操作(Operations)/9#收藏_星星_评分-star.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/1#展开文件夹-folder-open1.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/10#查看详情-view-detail.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/11#新建文件-new-file.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/12#反馈-feedback.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/13#开发文档-docs.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/13.1#默认配置-default-setting.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/14#任务-task.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/15#日志-log.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/16#域名记录-domain-log.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/17#添加域名解析-add-domain.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/18#域名生效验证-domain-valid.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/19#同步-Synchronize.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/2#新建文件夹-folder-add.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/20#黑名单-blacklist.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/21#文档搜索-doc-search.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/22#报表-report.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/23#委托-agency.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/3#展开文件夹-folder-open.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/30#图片-pic.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/31#图形-graph.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/32#截图-screenshot.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/33#上传图片-image-upload.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/34#word文档-word.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/35#doc文档-doc.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/36#ppt文档-ppt.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/37#表格文档-xlsx.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/4#历史文件夹-folder-history.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/40#存储-save.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/41#新建窗口-new-window.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/42#编辑-edit.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/42.1#恢复-redo.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/42.2#回退-undo.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/43#左对齐-align-left.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/44#居中对齐-align-center.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/45#右对齐-align-right.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/46#底部对齐-align-bottom.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/47#顶部对齐-align-top.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/48#横中对齐-align-middle.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/49#横向排列-x-arrange.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/5#文件夹-folder.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/50#纵向排列-y-arrange.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/51#表格-table.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/52#网格线-grid-line.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/53#网格线间距-grid-space.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/54#未选中-no-checked.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/55#半选-half-checked.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/56#选中-checked.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/57#未单选中-radio.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/58#单选选中-radio-checked.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/3-文档_编辑器(Document & Editor)/6#文件夹下载-folder-download.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/1#电脑-pc.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/10#实时数据-realtime-data.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/11#诊断分析-analysis.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/12#饼图-chart-pie.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/13#折线表-chart-line.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/14#指标_指数-index.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/15#指标_指数趋势-index-trend.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/16#周期性报表-period-report.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/17#配额-quota.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/2#监控信息_大屏-monitor.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/20#挂载存储-mount-storage.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/21#迁移数据库-migration-db.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/22#确认配置-confirm-configure.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/23#确认配置2-confirm-configure2.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/24#节点_关系图-nodes.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/25#创建节点-create-node.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/26#节点池-node-pool.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/27#工作负载-workloads.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/28#主机数据-host-data.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/29#替换协议-ip-replace.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/3#pycharm插件_电脑-pycharm.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/30#安装失败-install-failed.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/31#防护策略-protection-policy.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/32#合规策略-compliance-policy.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/33#空闲配额-idle-quota.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/34#离线-offline.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/35#已阻断_防护事件总数-protected-events.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/36#异常集群-failed-cluster.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/37#安全权限-privilege.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/38#安全策略-security-policy.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/4#选择对象-select-object.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/40#虚拟机移动-vm-move.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/41#链接_绑定-link.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/42#运行异常-exception.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/43#插件中心-add-ons.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/44#应用-apps.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/45#部署-deploy.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/46#编译-compile.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/47#集群-cluster.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/48#集群配置-cluster-config.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/49#集群事件-cluster-events.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/5#对象-object.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/50#规格变更-spec-change.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/51#已接入镜像仓-image-repo.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/52#镜像阻断策略-blocking-policy.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/53#异常镜像仓-failed-image-repo.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/6#命令行-cli-shell.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/60#已开启策略-strategy-enabled.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/61#未开启策略-strategy-disabled.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/62#主机修复失败-hostrepair-failed.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/63#主机修复中-host-repairing.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/64#主机修复成功-host-repair-successful.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/65#同步失败镜像仓-sync-failed-image-repo.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/66#同步镜像仓-sync-image-repo.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/67#同步成功镜像仓-sync-successful-image-repo.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/68#主机已取消扫描-host-scan-canceled.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/69#主机扫描失败-host-scan-failed.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/7#云命令行-cloud-shell.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/70#主机扫描成功-host-scaned.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/8#选择时间-select-time.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/80#扫描失败-scan-failed.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/81#扫描中-scanning.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/82#扫描成功-scaned.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/84#主机验证中-host-verifying.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/85#主机验证失败-host-deny.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/86#主机验证成功-host-verified.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/87#内网域名-domain-ip.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/88#反向解析-reverse-resolution.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/89#路由_线路-route.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/9#实时流量-realtime-flow.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/90#AI开发平台-modelarts.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/91#全球服务-global-services.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/92#健康中心-wellness-center.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/4-计算机_云(IT & Clouds)/93#公网域名-domain.svgis excluded by!**/*.svgnext/cloud-icons/svgs/base/5-用户_权限(User & Auth)/1#用户-user.svgis excluded by!**/*.svg
📒 Files selected for processing (13)
.gitignore(1 hunks)examples/sites/demos/apis/user.js(1 hunks)examples/sites/demos/pc/app/pop-upload/file-type.spec.ts(1 hunks)examples/sites/demos/pc/webdoc/i18n-en.md(1 hunks)examples/sites/demos/pc/webdoc/i18n.md(1 hunks)next/.gitignore(1 hunks)next/cloud-icons/.gitignore(1 hunks)next/cloud-icons/README.md(1 hunks)next/cloud-icons/index.html(1 hunks)next/cloud-icons/main.ts(1 hunks)next/cloud-icons/package.json(1 hunks)next/cloud-icons/scripts/__tests__/build.test.ts(1 hunks)next/cloud-icons/scripts/build.ts(1 hunks)
✅ Files skipped from review due to trivial changes (3)
- next/cloud-icons/.gitignore
- next/.gitignore
- next/cloud-icons/package.json
🧰 Additional context used
🪛 Markdownlint (0.37.0)
next/cloud-icons/README.md
10-10: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
🔇 Additional comments (6)
.gitignore (2)
72-73: LGTM! Good use of sectioning.The empty line and descriptive comment help organize the .gitignore file into logical sections, improving readability.
74-75: Consider fixing the potential typo in the filename.The ignore patterns are well-structured, but there might be a typo:
categorys.tsappears to be misspelled (standard English spelling would becategories.ts)Let's verify if this is a consistent naming convention across the project:
examples/sites/demos/pc/app/pop-upload/file-type.spec.ts (1)
21-22: LGTM! Improved readability of alert messages.The added spaces after colons in alert messages improve readability.
examples/sites/demos/apis/user.js (1)
75-89: LGTM! Well-documented new property.The
hover-expandproperty is well-structured with:
- Clear documentation in both languages
- Explicit conditions for usage (requires multiple=true)
- Version metadata
examples/sites/demos/pc/webdoc/i18n-en.md (1)
102-103: Verify version compatibility.The documentation states these changes are available from
@opentiny/[email protected]. Ensure this version is already released and available.next/cloud-icons/README.md (1)
58-58: Update placeholder URL for icon preview.The preview URL is currently a placeholder. Please update it with the actual URL.
Comment on lines
+15
to
+25
| test('测试生成css的正确性', () => { | ||
| let svg = loadSvg('./scripts/__tests__/点击-click.svg') | ||
| let css = genClass('click', svg.toMinifiedString()) | ||
|
|
||
| expect(css).toMatchSnapshot() | ||
|
|
||
| svg = loadSvg('./scripts/__tests__/函数工作流-FunctionGraph.svg') | ||
| css = genClass('fg', svg.toMinifiedString()) | ||
|
|
||
| expect(css).toMatchSnapshot() | ||
| }) |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Add test coverage for loadSvg function.
The test suite is missing coverage for the loadSvg function, which is a critical part of the icon processing pipeline.
+test('测试加载SVG文件的错误处理', () => {
+ expect(() => loadSvg('./non-existent.svg')).toThrow()
+ const svg = loadSvg('./scripts/__tests__/点击-click.svg')
+ expect(svg.toString()).not.toContain('<?xml')
+ expect(svg.toString()).not.toContain('<defs>')
+})📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| test('测试生成css的正确性', () => { | |
| let svg = loadSvg('./scripts/__tests__/点击-click.svg') | |
| let css = genClass('click', svg.toMinifiedString()) | |
| expect(css).toMatchSnapshot() | |
| svg = loadSvg('./scripts/__tests__/函数工作流-FunctionGraph.svg') | |
| css = genClass('fg', svg.toMinifiedString()) | |
| expect(css).toMatchSnapshot() | |
| }) | |
| test('测试生成css的正确性', () => { | |
| let svg = loadSvg('./scripts/__tests__/点击-click.svg') | |
| let css = genClass('click', svg.toMinifiedString()) | |
| expect(css).toMatchSnapshot() | |
| svg = loadSvg('./scripts/__tests__/函数工作流-FunctionGraph.svg') | |
| css = genClass('fg', svg.toMinifiedString()) | |
| expect(css).toMatchSnapshot() | |
| }) | |
| test('测试加载SVG文件的错误处理', () => { | |
| expect(() => loadSvg('./non-existent.svg')).toThrow() | |
| const svg = loadSvg('./scripts/__tests__/点击-click.svg') | |
| expect(svg.toString()).not.toContain('<?xml') | |
| expect(svg.toString()).not.toContain('<defs>') | |
| }) |
Comment on lines
+66
to
+78
| list.addEventListener('click', function (ev: MouseEvent) { | ||
| const target = ev.target as HTMLElement | ||
| const name = target.dataset.name | ||
| if (name) { | ||
| const cls = 'ci-' + name | ||
| const tag = `<i class="${cls}></i>` | ||
| const copyText = selCopy.value === 'all' ? tag : cls | ||
|
|
||
| navigator.clipboard.writeText(copyText) | ||
| lightTip.textContent = copyText + ' 复制成功' | ||
| lightTip.show() | ||
| } | ||
| }) |
There was a problem hiding this comment.
Add error handling for clipboard operations.
The clipboard operation could fail, especially on older browsers or with certain permissions.
- navigator.clipboard.writeText(copyText)
- lightTip.textContent = copyText + ' 复制成功'
- lightTip.show()
+ navigator.clipboard.writeText(copyText)
+ .then(() => {
+ lightTip.textContent = copyText + ' 复制成功'
+ lightTip.show()
+ })
+ .catch(error => {
+ console.error('Failed to copy:', error)
+ lightTip.textContent = '复制失败，请手动复制'
+ lightTip.show()
+ })📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| list.addEventListener('click', function (ev: MouseEvent) { | |
| const target = ev.target as HTMLElement | |
| const name = target.dataset.name | |
| if (name) { | |
| const cls = 'ci-' + name | |
| const tag = `<i class="${cls}></i>` | |
| const copyText = selCopy.value === 'all' ? tag : cls | |
| navigator.clipboard.writeText(copyText) | |
| lightTip.textContent = copyText + ' 复制成功' | |
| lightTip.show() | |
| } | |
| }) | |
| list.addEventListener('click', function (ev: MouseEvent) { | |
| const target = ev.target as HTMLElement | |
| const name = target.dataset.name | |
| if (name) { | |
| const cls = 'ci-' + name | |
| const tag = `<i class="${cls}></i>` | |
| const copyText = selCopy.value === 'all' ? tag : cls | |
| navigator.clipboard.writeText(copyText) | |
| .then(() => { | |
| lightTip.textContent = copyText + ' 复制成功' | |
| lightTip.show() | |
| }) | |
| .catch(error => { | |
| console.error('Failed to copy:', error) | |
| lightTip.textContent = '复制失败，请手动复制' | |
| lightTip.show() | |
| }) | |
| } | |
| }) |
Comment on lines
+9
to
+17
| const list = document.getElementById('list')! | ||
| const selCategory = document.getElementById('sel-category')! as HTMLSelectElement | ||
| const selType = document.getElementById('sel-type')! as HTMLSelectElement | ||
| const selColor = document.getElementById('sel-color')! as HTMLInputElement | ||
| const selCopy = document.getElementById('sel-copy')! as HTMLSelectElement | ||
| const lightTip = document.getElementById('lightTip')! | ||
| const btnHelp = document.getElementById('btnHelp')! as HTMLButtonElement | ||
| const dlgHelp = document.getElementById('dlgHelp')! as HTMLDialogElement | ||
| const helpCode = document.getElementById('helpCode')! as HTMLDialogElement |
There was a problem hiding this comment.
Add error handling for DOM element queries.
The code assumes all DOM elements exist. Consider adding error handling to prevent runtime errors.
-const list = document.getElementById('list')!
-const selCategory = document.getElementById('sel-category')! as HTMLSelectElement
+const getRequiredElement = <T extends HTMLElement>(id: string): T => {
+ const element = document.getElementById(id)
+ if (!element) throw new Error(`Required element #${id} not found`)
+ return element as T
+}
+
+const list = getRequiredElement<HTMLElement>('list')
+const selCategory = getRequiredElement<HTMLSelectElement>('sel-category')📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| const list = document.getElementById('list')! | |
| const selCategory = document.getElementById('sel-category')! as HTMLSelectElement | |
| const selType = document.getElementById('sel-type')! as HTMLSelectElement | |
| const selColor = document.getElementById('sel-color')! as HTMLInputElement | |
| const selCopy = document.getElementById('sel-copy')! as HTMLSelectElement | |
| const lightTip = document.getElementById('lightTip')! | |
| const btnHelp = document.getElementById('btnHelp')! as HTMLButtonElement | |
| const dlgHelp = document.getElementById('dlgHelp')! as HTMLDialogElement | |
| const helpCode = document.getElementById('helpCode')! as HTMLDialogElement | |
| const getRequiredElement = <T extends HTMLElement>(id: string): T => { | |
| const element = document.getElementById(id) | |
| if (!element) throw new Error(`Required element #${id} not found`) | |
| return element as T | |
| } | |
| const list = getRequiredElement<HTMLElement>('list') | |
| const selCategory = getRequiredElement<HTMLSelectElement>('sel-category') | |
| const selType = getRequiredElement<HTMLSelectElement>('sel-type') | |
| const selColor = getRequiredElement<HTMLInputElement>('sel-color') | |
| const selCopy = getRequiredElement<HTMLSelectElement>('sel-copy') | |
| const lightTip = getRequiredElement<HTMLElement>('lightTip') | |
| const btnHelp = getRequiredElement<HTMLButtonElement>('btnHelp') | |
| const dlgHelp = getRequiredElement<HTMLDialogElement>('dlgHelp') | |
| const helpCode = getRequiredElement<HTMLDialogElement>('helpCode') |
Comment on lines
+148
to
+150
| let files = await fg(['./svgs/**/*.svg']) | ||
| files.map((file) => processSvg(file)) | ||
| console.log(chalk.blue('> 遍历处理文件成功\n')) |
There was a problem hiding this comment.
Add path sanitization for file operations.
The glob pattern could potentially access files outside the intended directory.
-let files = await fg(['./svgs/**/*.svg'])
+const ALLOWED_DIRS = ['base', 'svc', 'ext']
+let files = await fg(['./svgs/**/*.svg'])
+files = files.filter(file => {
+ const dir = file.split('/')[2]
+ return ALLOWED_DIRS.includes(dir)
+})📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| let files = await fg(['./svgs/**/*.svg']) | |
| files.map((file) => processSvg(file)) | |
| console.log(chalk.blue('> 遍历处理文件成功\n')) | |
| const ALLOWED_DIRS = ['base', 'svc', 'ext'] | |
| let files = await fg(['./svgs/**/*.svg']) | |
| files = files.filter(file => { | |
| const dir = file.split('/')[2] | |
| return ALLOWED_DIRS.includes(dir) | |
| }) | |
| files.map((file) => processSvg(file)) | |
| console.log(chalk.blue('> 遍历处理文件成功\n')) |
Comment on lines
+46
to
+79
| export function loadSvg(svgPath: string) { | ||
| const content = fs.readFileSync(svgPath, 'utf8') | ||
| const svg = new SVG(content) | ||
|
|
||
| try { | ||
| cleanupSVG(svg) | ||
| runSVGO(svg, { | ||
| plugins: [ | ||
| 'prefixIds', | ||
| { | ||
| name: 'removeDefs', | ||
| fn: () => { | ||
| return { | ||
| element: { | ||
| enter: (node, parentNode) => { | ||
| // 具有渐变的，则不过滤了 | ||
| if (content.includes('<linearGradient')) return | ||
|
|
||
| if (node.name === 'defs') { | ||
| parentNode.children = parentNode.children.filter((child) => child !== node) | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| }) | ||
| deOptimisePaths(svg) | ||
| } catch (error) { | ||
| console.log(chalk.red('处理svg时出错'), svgPath, error) | ||
| } | ||
| return svg | ||
| } |
There was a problem hiding this comment.
Enhance error handling in loadSvg function.
The function catches errors but continues execution, which could lead to corrupted output.
export function loadSvg(svgPath: string) {
+ if (!fs.existsSync(svgPath)) {
+ throw new Error(`SVG file not found: ${svgPath}`)
+ }
const content = fs.readFileSync(svgPath, 'utf8')
+ if (!content.includes('<svg')) {
+ throw new Error(`Invalid SVG file: ${svgPath}`)
+ }
const svg = new SVG(content)
try {
cleanupSVG(svg)
runSVGO(svg)
deOptimisePaths(svg)
} catch (error) {
- console.log(chalk.red('处理svg时出错'), svgPath, error)
+ throw new Error(`Failed to process SVG ${svgPath}: ${error}`)
}
return svg
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| export function loadSvg(svgPath: string) { | |
| const content = fs.readFileSync(svgPath, 'utf8') | |
| const svg = new SVG(content) | |
| try { | |
| cleanupSVG(svg) | |
| runSVGO(svg, { | |
| plugins: [ | |
| 'prefixIds', | |
| { | |
| name: 'removeDefs', | |
| fn: () => { | |
| return { | |
| element: { | |
| enter: (node, parentNode) => { | |
| // 具有渐变的，则不过滤了 | |
| if (content.includes('<linearGradient')) return | |
| if (node.name === 'defs') { | |
| parentNode.children = parentNode.children.filter((child) => child !== node) | |
| } | |
| } | |
| } | |
| } | |
| } | |
| } | |
| ] | |
| }) | |
| deOptimisePaths(svg) | |
| } catch (error) { | |
| console.log(chalk.red('处理svg时出错'), svgPath, error) | |
| } | |
| return svg | |
| } | |
| export function loadSvg(svgPath: string) { | |
| if (!fs.existsSync(svgPath)) { | |
| throw new Error(`SVG file not found: ${svgPath}`) | |
| } | |
| const content = fs.readFileSync(svgPath, 'utf8') | |
| if (!content.includes('<svg')) { | |
| throw new Error(`Invalid SVG file: ${svgPath}`) | |
| } | |
| const svg = new SVG(content) | |
| try { | |
| cleanupSVG(svg) | |
| runSVGO(svg, { | |
| plugins: [ | |
| 'prefixIds', | |
| { | |
| name: 'removeDefs', | |
| fn: () => { | |
| return { | |
| element: { | |
| enter: (node, parentNode) => { | |
| // 具有渐变的，则不过滤了 | |
| if (content.includes('<linearGradient')) return | |
| if (node.name === 'defs') { | |
| parentNode.children = parentNode.children.filter((child) => child !== node) | |
| } | |
| } | |
| } | |
| } | |
| } | |
| } | |
| ] | |
| }) | |
| deOptimisePaths(svg) | |
| } catch (error) { | |
| throw new Error(`Failed to process SVG ${svgPath}: ${error}`) | |
| } | |
| return svg | |
| } |
| @@ -0,0 +1,148 @@ | |||
| <!doctype html> | |||
| <html lang="en"> | |||
There was a problem hiding this comment.
Fix language inconsistency.
The document's lang attribute is set to "en" but contains Chinese content (title). This affects accessibility and SEO.
Apply this diff:
-<html lang="en">
+<html lang="zh">
- <title>云规范图标集预览</title>
+ <title>Cloud Icon Set Preview</title>Also applies to: 6-6
Comment on lines
+102
to
+105
| <select id="sel-type" is="ui-select"> | ||
| <option value="ci">class</option> | ||
| <option value="ci">json-data</option> | ||
| </select> |
There was a problem hiding this comment.
Fix duplicate select options.
The sel-type select element contains duplicate options with the same value "ci".
<select id="sel-type" is="ui-select">
<option value="ci">class</option>
- <option value="ci">json-data</option>
+ <option value="json">json-data</option>
</select>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| <select id="sel-type" is="ui-select"> | |
| <option value="ci">class</option> | |
| <option value="ci">json-data</option> | |
| </select> | |
| <select id="sel-type" is="ui-select"> | |
| <option value="ci">class</option> | |
| <option value="json">json-data</option> | |
| </select> |
Comment on lines
+122
to
+143
| <dialog id="dlgHelp" is="ui-dialog"> | ||
| <div class="dlg-root"> | ||
| <h3>1、安装</h3> | ||
| <div>在项目中安装: <code>npm i @opentiny/cloud-icons</code></div> | ||
| <h3>2、通过css 引用</h3> | ||
| <div>在工程中引入图标的css文件： <code>import "@opentiny/cloud-icons/style/all.css"</code></div> | ||
| <h3>3、通过 @unocss/preset-icons 插件按需引用</h3> | ||
| <div> | ||
| 例如vite工程中，配置UnoCss的图标插件： | ||
| <pre id="helpCode"></pre> | ||
| </div> | ||
|
|
||
| <h3>4、使用图标</h3> | ||
| <ul> | ||
| <li> | ||
| 通过图标名引用所需图标： <code><i class="ci-search"></i></code> 会得到 | ||
| <i class="ci-search"></i> | ||
| </li> | ||
| <li>通过修改图标的 <code>color \ font-size</code> 控制图标的大小和颜色。</li> | ||
| </ul> | ||
| </div> | ||
| </dialog> |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Enhance dialog accessibility and user experience.
The help dialog needs improvements for better accessibility and user interaction:
- Add close button
- Support keyboard navigation (Esc to close)
- Add proper ARIA attributes
Example improvements:
-<dialog id="dlgHelp" is="ui-dialog">
+<dialog id="dlgHelp" is="ui-dialog" aria-labelledby="dlg-title" aria-modal="true">
<div class="dlg-root">
+ <div class="dialog-header">
+ <h2 id="dlg-title">使用说明</h2>
+ <button class="close-button" aria-label="Close dialog">×</button>
+ </div>
<!-- existing content -->
</div>
</dialog>Committable suggestion skipped: line range outside the PR's diff.
Comment on lines
+89
to
+120
| <div id="app"> | ||
| <h1 style="text-align: center">云规范图标集预览</h1> | ||
| <div class="settings"> | ||
| <div> | ||
| <label> 选择图标集:</label> | ||
| <select id="sel-category" is="ui-select"> | ||
| <option value="base">系统图标</option> | ||
| <option value="svc">服务图标</option> | ||
| <option value="ext">扩展图标</option> | ||
| <option value="stat">状态图标</option> | ||
| </select> | ||
| <span class="hide"> | ||
| <label> 引用方式:</label> | ||
| <select id="sel-type" is="ui-select"> | ||
| <option value="ci">class</option> | ||
| <option value="ci">json-data</option> | ||
| </select> | ||
| </span> | ||
| <label> 图标颜色:</label> | ||
| <input id="sel-color" type="color" is="ui-color" value="#000000" /> | ||
| <label> 复制方式:</label> | ||
| <select id="sel-copy" is="ui-select"> | ||
| <option value="all">完整标签</option> | ||
| <option value="only-name">图标类名</option> | ||
| </select> | ||
| <ui-lighttip id="lightTip" type="success">复制成功</ui-lighttip> | ||
| </div> | ||
| <div> | ||
| <button id="btnHelp" type="primary" class="ui-button">使用说明</button> | ||
| </div> | ||
| </div> | ||
| <div id="list"></div> |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Improve accessibility with ARIA labels and internationalization.
- Add ARIA labels for form controls
- Consider internationalizing the text content
Example improvements:
-<select id="sel-category" is="ui-select">
+<select id="sel-category" is="ui-select" aria-label="Select icon category">
-<input id="sel-color" type="color" is="ui-color" value="#000000" />
+<input id="sel-color" type="color" is="ui-color" value="#000000" aria-label="Select icon color" />
-<button id="btnHelp" type="primary" class="ui-button">使用说明</button>
+<button id="btnHelp" type="primary" class="ui-button" aria-label="Open help dialog">使用说明</button>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| <div id="app"> | |
| <h1 style="text-align: center">云规范图标集预览</h1> | |
| <div class="settings"> | |
| <div> | |
| <label> 选择图标集:</label> | |
| <select id="sel-category" is="ui-select"> | |
| <option value="base">系统图标</option> | |
| <option value="svc">服务图标</option> | |
| <option value="ext">扩展图标</option> | |
| <option value="stat">状态图标</option> | |
| </select> | |
| <span class="hide"> | |
| <label> 引用方式:</label> | |
| <select id="sel-type" is="ui-select"> | |
| <option value="ci">class</option> | |
| <option value="ci">json-data</option> | |
| </select> | |
| </span> | |
| <label> 图标颜色:</label> | |
| <input id="sel-color" type="color" is="ui-color" value="#000000" /> | |
| <label> 复制方式:</label> | |
| <select id="sel-copy" is="ui-select"> | |
| <option value="all">完整标签</option> | |
| <option value="only-name">图标类名</option> | |
| </select> | |
| <ui-lighttip id="lightTip" type="success">复制成功</ui-lighttip> | |
| </div> | |
| <div> | |
| <button id="btnHelp" type="primary" class="ui-button">使用说明</button> | |
| </div> | |
| </div> | |
| <div id="list"></div> | |
| <div id="app"> | |
| <h1 style="text-align: center">云规范图标集预览</h1> | |
| <div class="settings"> | |
| <div> | |
| <label> 选择图标集:</label> | |
| <select id="sel-category" is="ui-select" aria-label="Select icon category"> | |
| <option value="base">系统图标</option> | |
| <option value="svc">服务图标</option> | |
| <option value="ext">扩展图标</option> | |
| <option value="stat">状态图标</option> | |
| </select> | |
| <span class="hide"> | |
| <label> 引用方式:</label> | |
| <select id="sel-type" is="ui-select"> | |
| <option value="ci">class</option> | |
| <option value="ci">json-data</option> | |
| </select> | |
| </span> | |
| <label> 图标颜色:</label> | |
| <input id="sel-color" type="color" is="ui-color" value="#000000" aria-label="Select icon color" /> | |
| <label> 复制方式:</label> | |
| <select id="sel-copy" is="ui-select"> | |
| <option value="all">完整标签</option> | |
| <option value="only-name">图标类名</option> | |
| </select> | |
| <ui-lighttip id="lightTip" type="success">复制成功</ui-lighttip> | |
| </div> | |
| <div> | |
| <button id="btnHelp" type="primary" class="ui-button" aria-label="Open help dialog">使用说明</button> | |
| </div> | |
| </div> | |
| <div id="list"></div> |
kagol
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
Release Notes
New Features
Documentation
Chores
.gitignorefiles to exclude specific cache and generated filesTests