Add new Hanyu Pinyin conversion support #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zonble
commented
Feb 18, 2025
zonble
commented
- Add new Ctrl + Enter option to let users to input Hanyu Pinyin readings
- Ads new service menu items to let users to convert selected text Hanyu Pinyin
- Convert various test cases from XCTest to new Swift Testing framework
- Let CI jobs to add comments about code coverage on the commits on GitHub
Also corrects the service menu for Pinyin.
.github/collect_swift_coverage.sh
Outdated
| } | ||
| print sep_line | ||
| } else if ($0 !~ /^-+$/) { | ||
| # 處理數據行，確保每個欄位之間有空格 |
There was a problem hiding this comment.
recommend:
數據行 --> 資料列
nitpick:
表頭 --> 標題列
生成 --> 產生
xatier
reviewed
Feb 20, 2025
| local input="$1" | ||
|
|
||
| echo "$input" | tr '-' '\n' | sed '/^$/d' | awk ' | ||
| BEGIN { |
There was a problem hiding this comment.
suggestion: we can put this script to a file and invoke it as awk -f <file>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.