[TorchFX]: Test Fast Bias Correction algorithm #2812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
NNCF PT
|
@anzr299, Nice work! |
alexsu52
requested changes
Jul 24, 2024
tests/torch/fx/graph_manager.py
Outdated
| from nncf.torch.model_graph_manager import find_const_node_in_constant_subgraph | ||
|
|
||
|
|
||
| def is_node_with_bias(node: NNCFNode, nncf_graph: NNCFGraph) -> bool: |
There was a problem hiding this comment.
@anzr299, @daniil-lyakhov, it looks like, this is general functions and can be used in the fast bias correction. Please consider possible refactoring to use functions in the NNCF algorithms.
There was a problem hiding this comment.
I have removed it for this PR for now. We can add it back in a follow up PR when refactoring
|
@anzr299, please rebase your changes |
github-actions
bot
removed
NNCF Common
Done |
daniil-lyakhov
requested changes
Jul 29, 2024
|
|
||
| @staticmethod | ||
| def backend_specific_model(model: torch.nn.Module, tmp_dir: str): | ||
| fx_model = TestTorchFXFBCAlgorithm._get_fx_model(model) |
There was a problem hiding this comment.
Please move code from _get_fx_model to the backend_specific_model` function
daniil-lyakhov
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add Fast BC test in tests/torch/fx.
Related tickets
#2809
Tests
The implemented test class inherits from the template for Fast bias correction.