[Torch FX] PTQ MinMax parameters test #2989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@rk119, thank you for the contribution! One small comment from my side:
tests/torch/fx/test_ptq_params.py
Outdated
Comment on lines
53
to
71
| class LinearTestModel(nn.Module): | ||
| INPUT_SIZE = None | ||
|
|
||
| def __init__(self): | ||
| super().__init__() | ||
| self.conv1 = create_conv(3, 3, 1) | ||
| self.bn1 = create_bn(3) | ||
| self.relu = nn.ReLU() | ||
| self.avg_pool = nn.AdaptiveAvgPool2d(1) | ||
| self.conv2 = create_conv(3, 1, 1) | ||
| self.bn2 = create_bn(1) | ||
|
|
||
| def forward(self, x): | ||
| x = self.relu(self.conv1(x)) | ||
| x = self.bn1(x) | ||
| x = self.avg_pool(x) | ||
| x = self.relu(self.conv2(x)) | ||
| x = self.bn2(x) | ||
| return x |
There was a problem hiding this comment.
@rk119, could you please put this model to nncf/tests/torch/test_models/synthetic.py with a name LinearPTQParamsTestModel and reuse it in both Torch and TorchFX tests?
There was a problem hiding this comment.
@rk119, could you please put this model to
nncf/tests/torch/test_models/synthetic.pywith a name LinearPTQParamsTestModel and reuse it in both Torch and TorchFX tests?
Alright.
daniil-lyakhov
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
New test file added in tests/torch/fx. Implemented TemplateTestPTQParams for PTQ MinMax for TorchFX backend.
Related tickets
#2873