Whisper pipeline: support stateful decoder #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
no-match-files
and removed
category: samples
github-actions
bot
added
the
category: tokenizers
github-actions
bot
removed
the
category: tokenizers
as-suvorov
commented
Jan 9, 2025
| } // namespace | ||
|
|
||
| namespace ov::genai { | ||
| WhisperWithPastDecoder::WhisperWithPastDecoder(const std::filesystem::path& models_path, |
There was a problem hiding this comment.
@ilya-lavrenov @Wovchena I want to add deprecation note for this ctor. I saw OPENVINO_DEPRECATED macros but I think it doesn't fit here as I want to warn user at runtime.
Can I add just std::cout << "[Warning] Whisper decoder with past deprecated ..." ? Does OV have logging utilities we can reuse? Or there is a better way?
There was a problem hiding this comment.
we don't have a better way than a message in runtime
ilya-lavrenov
approved these changes
Jan 10, 2025
Wovchena
approved these changes
Jan 13, 2025
|
|
||
| class Logger { | ||
| public: | ||
| static void warn(std::string message) { |
There was a problem hiding this comment.
Suggested change
| static void warn(std::string message) { | |
| static void warn(const std::string& message) { |
| const ov::AnyMap& properties) { | ||
| Logger::warn("Whisper decoder models with past is deprecated. Support will be removed in 2026.0.0 release.\n" | ||
| "To obtain stateful decoder model use latest `optimum-intel` package:\n" | ||
| "pip install optimum-intel@git+https://github.com/huggingface/optimum-intel.git\n" |
There was a problem hiding this comment.
You can provide the minimum version containing stateful whisper by specifying pip install "optimum-intel>=VERSION"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: 159473
Optimum-intel PR: huggingface/optimum-intel#1078
This PR switches optimum-intel in tests to stateful seq2seq branch. Tests check both stateful and with past decoders. Once optimum-intel PR is merged I'll switch version back to master.