-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GHA] Samples tests refactoring #1661
Merged
ilya-lavrenov
merged 78 commits into
openvinotoolkit:master
from
mryzhov:gha/samples_tests
Feb 21, 2025
Merged
[GHA] Samples tests refactoring #1661
ilya-lavrenov
merged 78 commits into
openvinotoolkit:master
from
mryzhov:gha/samples_tests
Feb 21, 2025
+408
−245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wovchena
requested changes
Feb 4, 2025
Wovchena
requested changes
Feb 5, 2025
@@ -32,6 +32,8 @@ classifiers = [ | |||
dependencies = [ | |||
"openvino_tokenizers~=2025.1.0.0.dev" | |||
] | |||
[project.optional-dependencies] | |||
testing = ["pytest>=6.0"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have tests requirements here https://github.com/openvinotoolkit/openvino.genai/blob/master/tests/python_tests/requirements.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- we don't need to install all of them
- we don't have this file when install the wheel, will need to additionally checkout it.
- it would be better to split test requirements by groups and manage them in toml file
AlexKoff88
reviewed
Feb 13, 2025
mryzhov
commented
Feb 20, 2025
Loading status checks…
ilya-lavrenov
approved these changes
Feb 20, 2025
Wovchena
requested changes
Feb 20, 2025
Wovchena
approved these changes
Feb 21, 2025
Co-authored-by: Vladimir Zlobin <[email protected]>
ilya-lavrenov
pushed a commit
that referenced
this pull request
Feb 25, 2025
Ported changed into the Windows pipelines - #1661
ilya-lavrenov
pushed a commit
that referenced
this pull request
Feb 26, 2025
Ported changed into the Windows pipelines - #1661
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimized the samples testing in CI pipelines by reusing already converted models, addressing the bottleneck caused by the time-consuming conversion step: