Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GHA] Samples tests refactoring #1661

Merged
merged 78 commits into from
Feb 21, 2025

Conversation

mryzhov
Copy link
Contributor

@mryzhov mryzhov commented Jan 31, 2025

Optimized the samples testing in CI pipelines by reusing already converted models, addressing the bottleneck caused by the time-consuming conversion step:

  • Wrapped c++/python samples calls to the pytest fixtures
  • Added test labels to be able to test only c++/python or tests for specific model types only
  • Replaced the large models with smaller ones.
  • added an option to cleanup models and cache during the tests --cleanup-cache (it is disabled by default)

@github-actions github-actions bot added category: GHA CI based on Github actions category: cmake / build Cmake scripts no-match-files labels Jan 31, 2025
@mryzhov mryzhov marked this pull request as ready for review February 3, 2025 10:25
@ilya-lavrenov ilya-lavrenov added this to the 2025.1 milestone Feb 3, 2025
@@ -32,6 +32,8 @@ classifiers = [
dependencies = [
"openvino_tokenizers~=2025.1.0.0.dev"
]
[project.optional-dependencies]
testing = ["pytest>=6.0"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. we don't need to install all of them
  2. we don't have this file when install the wheel, will need to additionally checkout it.
  3. it would be better to split test requirements by groups and manage them in toml file

@mryzhov mryzhov requested a review from Wovchena February 20, 2025 13:31
@Wovchena Wovchena added this pull request to the merge queue Feb 21, 2025
@mryzhov mryzhov removed this pull request from the merge queue due to a manual request Feb 21, 2025
Co-authored-by: Vladimir Zlobin <[email protected]>
@mryzhov mryzhov enabled auto-merge February 21, 2025 09:07
@ilya-lavrenov ilya-lavrenov merged commit 1505056 into openvinotoolkit:master Feb 21, 2025
63 of 67 checks passed
ilya-lavrenov pushed a commit that referenced this pull request Feb 25, 2025
Ported changed into the Windows pipelines -
#1661
ilya-lavrenov pushed a commit that referenced this pull request Feb 26, 2025
Ported changed into the Windows pipelines - #1661
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: cmake / build Cmake scripts category: GHA CI based on Github actions no-match-files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants