Skip to content

Commit

Permalink
ci: Fix OPTS not being passed to OSX builds.
Browse files Browse the repository at this point in the history
Before GHA, OPTS were always passed as an argument for a *-build.sh
script.  But that changed.  Linux builds are using the OPTS variable
from the environment, but OSX script does not, so the options are
currently ignored.

That wasn't a big issue until now, because SSL was not available or
the build actually worked on newer branches.  But GHA recently updated
OpenSSL to 3.0+ and we have deprecation warnings on branches that do
not support OpenSSL 3.0+ (branch 2.16) and that breaks the build.

Fixes: 6cb2f5a ("github: Add GitHub Actions workflow.")
Reviewed-by: David Marchand <[email protected]>
Signed-off-by: Ilya Maximets <[email protected]>
  • Loading branch information
igsilya committed Aug 4, 2023
1 parent 2a0dbd5 commit d36ca88
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .ci/osx-build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ function configure_ovs()
./boot.sh && ./configure $*
}

configure_ovs $EXTRA_OPTS $*
configure_ovs $EXTRA_OPTS $OPTS $*

if [ "$CC" = "clang" ]; then
make CFLAGS="$CFLAGS -Wno-error=unused-command-line-argument"
Expand Down

0 comments on commit d36ca88

Please sign in to comment.