Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WPAPSK CPU formats: Remove dependency on OpenSSL for 802.11w support #5614

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

magnumripper
Copy link
Member

Use the same simple CMAC-AES-128 implementation we have in OpenCL.

Use the same simple CMAC-AES-128 implementation we have in OpenCL.
@magnumripper
Copy link
Member Author

I should have fixed this back in 2017 when I added the CMAC code for OpenCL. As expected, I see no change in performance - the AES-CMAC shouldn't be significant.

Copy link
Member

@solardiz solardiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review the CMAC code itself, but if the bots are happy it should be right.

*/

#include "cmac.h"
#include "common.h"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do we use from common.h here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the MIN() macro.

@magnumripper magnumripper merged commit 15f2f58 into openwall:bleeding-jumbo Dec 18, 2024
35 of 36 checks passed
@magnumripper magnumripper deleted the cmac-nossl branch December 18, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants