Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace BaseWallet with BaseWallet2 #1093

Merged
merged 8 commits into from
Jan 31, 2024
Merged

feat: replace BaseWallet with BaseWallet2 #1093

merged 8 commits into from
Jan 31, 2024

Conversation

xprazak2
Copy link
Contributor

@xprazak2 xprazak2 commented Dec 20, 2023

  • replaces BaseWallet with BaseWallet2 in all crates.
  • adds implementation of BaseWallet2 for AgencyClientWallet and MockWallet

@xprazak2 xprazak2 force-pushed the wallet-swap branch 2 times, most recently from e505d3e to 9fa20d1 Compare December 28, 2023 12:25
@xprazak2 xprazak2 changed the base branch from x25519 to indy-record-wallet December 28, 2023 12:26
@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2023

Codecov Report

Attention: 348 lines in your changes are missing coverage. Please review.

Comparison is base (b837fcb) 0.05% compared to head (50965c2) 0.05%.

Files Patch % Lines
.../aries_vcx_core/src/wallet/agency_client_wallet.rs 0.00% 59 Missing ⚠️
aries/aries_vcx_core/src/wallet/entry_tags.rs 0.00% 46 Missing ⚠️
aries/aries_vcx/src/utils/encryption_envelope.rs 0.00% 37 Missing ⚠️
aries/aries_vcx_core/src/wallet/mock_wallet.rs 0.00% 35 Missing ⚠️
aries/aries_vcx_core/src/wallet/indy/mod.rs 0.00% 27 Missing ⚠️
...es/aries_vcx_core/src/wallet/base_wallet/record.rs 0.00% 18 Missing ⚠️
aries/aries_vcx_core/src/wallet/indy/indy_tags.rs 0.00% 17 Missing ⚠️
...es/aries_vcx_core/src/anoncreds/credx_anoncreds.rs 0.00% 15 Missing ⚠️
.../aries_vcx_core/src/wallet/base_wallet/did_data.rs 0.00% 12 Missing ⚠️
...es/misc/wallet_migrator/src/vdrtools2credx/conv.rs 0.00% 12 Missing ⚠️
... and 15 more
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #1093    +/-   ##
======================================
  Coverage   0.05%   0.05%            
======================================
  Files        479     475     -4     
  Lines      24338   23870   -468     
  Branches    4367    4273    -94     
======================================
  Hits          13      13            
+ Misses     24324   23856   -468     
  Partials       1       1            
Flag Coverage Δ
unittests-aries-vcx 0.05% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xprazak2 xprazak2 force-pushed the wallet-swap branch 6 times, most recently from 2f63acc to 7e2d522 Compare December 29, 2023 10:10
@xprazak2 xprazak2 force-pushed the indy-record-wallet branch 5 times, most recently from d7199da to 748ab8a Compare January 3, 2024 06:58
@xprazak2 xprazak2 force-pushed the wallet-swap branch 3 times, most recently from bd14530 to eb0014d Compare January 3, 2024 07:42
@xprazak2 xprazak2 marked this pull request as ready for review January 3, 2024 13:01
Patrik-Stas
Patrik-Stas previously approved these changes Jan 3, 2024
@xprazak2 xprazak2 force-pushed the indy-record-wallet branch 5 times, most recently from bc3a5c6 to 91c0004 Compare January 4, 2024 15:16
@xprazak2 xprazak2 force-pushed the indy-record-wallet branch 2 times, most recently from 1cf5beb to f85aedc Compare January 12, 2024 08:48
@xprazak2 xprazak2 force-pushed the wallet-swap branch 4 times, most recently from d290e59 to e531c6e Compare January 26, 2024 11:08
Signed-off-by: Ondrej Prazak <[email protected]>
@xprazak2 xprazak2 force-pushed the wallet-swap branch 4 times, most recently from 2fd55fc to 7b2ca4a Compare January 26, 2024 14:25
Signed-off-by: Ondrej Prazak <[email protected]>
Patrik-Stas
Patrik-Stas previously approved these changes Jan 29, 2024
Signed-off-by: Ondrej Prazak <[email protected]>
Patrik-Stas
Patrik-Stas previously approved these changes Jan 31, 2024
Signed-off-by: Ondrej Prazak <[email protected]>
Signed-off-by: Ondrej Prazak <[email protected]>
Copy link
Contributor

@Patrik-Stas Patrik-Stas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets goooooo 🚀

@Patrik-Stas Patrik-Stas merged commit 7f2126d into main Jan 31, 2024
29 checks passed
@Patrik-Stas Patrik-Stas deleted the wallet-swap branch January 31, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants