Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move random utils from test_utils to aries_vcx_core, closes #1101 #1104

Closed
wants to merge 1 commit into from

Conversation

xprazak2
Copy link
Contributor

@xprazak2 xprazak2 commented Jan 10, 2024

test_utils heavily relies on types from aries_vcx_core, so removing it as a dependency would mean remove essentially all the setup functions. The approach here is as follows:

  • remove test_utils as a crate, move the code into aries_vcx_core
  • add test_utils feature flag
  • use aries_vcx_core with test_utils feature flag as a dev dependency where needed

@mirgee mirgee linked an issue Jan 10, 2024 that may be closed by this pull request
@xprazak2 xprazak2 force-pushed the crate-squash branch 2 times, most recently from 63d081f to ad409db Compare January 10, 2024 11:11
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (41ea29f) 0.05% compared to head (b186115) 0.05%.

❗ Current head b186115 differs from pull request most recent head 1088388. Consider uploading reports for the commit 1088388 to get more accurate results

Files Patch % Lines
...ries/misc/legacy/diddoc_legacy/src/aries/diddoc.rs 0.00% 4 Missing ⚠️
aries/misc/legacy/libvcx_logger/src/error.rs 0.00% 3 Missing ⚠️
aries/misc/legacy/libvcx_logger/src/lib.rs 0.00% 2 Missing ⚠️
aries/aries_vcx/src/common/credentials/encoding.rs 0.00% 1 Missing ⚠️
...ies/aries_vcx/src/handlers/out_of_band/receiver.rs 0.00% 1 Missing ⚠️
aries/aries_vcx/src/handlers/util.rs 0.00% 1 Missing ⚠️
aries/aries_vcx/src/protocols/did_exchange/mod.rs 0.00% 1 Missing ⚠️
aries/aries_vcx_core/src/test_utils/devsetup.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1104      +/-   ##
========================================
- Coverage   0.05%   0.05%   -0.01%     
========================================
  Files        472     472              
  Lines      24109   24642     +533     
  Branches    4336    4540     +204     
========================================
  Hits          13      13              
- Misses     24095   24628     +533     
  Partials       1       1              
Flag Coverage Δ
unittests-aries-vcx 0.05% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xprazak2 xprazak2 force-pushed the crate-squash branch 12 times, most recently from 1088388 to 783d034 Compare January 12, 2024 09:52
@xprazak2
Copy link
Contributor Author

Not needed, closing.

@xprazak2 xprazak2 closed this Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove aries_vcx_core as dependency of test_utils
2 participants